mne-tools / mne-tools/mne-python
Consolidation once Epochs have Annotations
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
Describe the bug
Noticed in https://github.com/mne-tools/mne-python/blob/077d311204efb0f947a8fbe57419ced0fc1769ff/mne/epochs.py#L3733 that there's functions that actually need the "original" raw sfreq.
Once Epochs have Annotations, I wonder if there's more to consolidate.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in mne/epochs.py around line 3733 and inspect the functions that still require the original raw sampling frequency. Then audit how Epochs with Annotations are handled to determine what can be consolidated. Done means the relevant behavior has a clear consolidated implementation and remains correct for annotated Epochs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100