mne-tools / mne-tools/mne-python

ENH: Remaining stuff for Epochs annotations

Open
#10,145 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ENH
Dominant language
Python
Stars
3.5k
Forks
1.6k
Avg merge
1d 6h
Merged PRs (30d)
100

Description

From https://github.com/mne-tools/mne-python/pull/9969, @adam2392 we should take care of these before 1.0. Creating this issue so that we don't forget:

  • Annotations will be lost on save. (#10019)
  • It is not yet possible to add annotations to the Epochs object programmatically (via code)

The first one here seems less critical to me, so I think we could leave it for 1.1, and the second one is too hard for 1.0:

  • Concatenating :class:~mne.Epochs objects that contain annotations is not supported, and any annotations will be dropped when concatenating.
  • It is not yet possible to add annotations to the Epochs object interactively (through the plot window)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review PR #9969 and the linked issue #10019 to understand the existing Epochs annotation work. Select and scope one of the unchecked behaviors—programmatic addition, concatenation, or interactive editing—and define done as that behavior working without dropping annotations.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data, data-visualization
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.