Make sure that the include files are copied everytime make is written.

Open
#14 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
cmake, cpp
Domain
build-system

Research direction

Start with the CMake configuration used by cmake ../ and inspect how the include directory is copied into build/include. Reproduce the issue by editing summary_writer_impl.hpp after the first make, then run make again; done means the changed header is reflected in the subsequent build.

Written by the indexing model from the issue text.

Description

build system help wanted

While reviewing a PR I noticed a bug.

Whenever a user hits make two times consecutively while building the repository, if there is any change in the include directory, the given change is not reflected and make does not build that change. The reason might be because the build/include once created by copying the include folder, then the changes are not reflected.

Steps to Reproduce
mkdir build && cd ./build
cmake ../
make 
Then make some changes in any file (For example, in `summary_writer_impl.hpp` change the method name.)
make
Actual Behaviour

The changes made in summary_writer_impl.hpp are not getting reflected while building and the build compiles as normal.

Expected Behaviour

The changes should get reflected.

Dominant language
C++
Stars
13
Forks
8
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mlpack/mlboard

All issues in mlpack/mlboard

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.