mit-acl / mit-acl/dpgo

1 FAILED TEST: testDPGO.testRobustSinglePoseAveraging

Open
#2 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
205
Forks
36
PR merge metrics
No merged PRs in 30d

Description

@yuluntian in extending testStiefelProjection:

https://github.com/mit-acl/dpgo/blob/a238090c6427ad509370bd6c302bcac82c1be95f/tests/testUtils.cpp#L28

to cover an increased number of iterations (say j < 100):

https://github.com/mit-acl/dpgo/blob/a238090c6427ad509370bd6c302bcac82c1be95f/tests/testUtils.cpp#L32

testRobustSinglePoseAveraging fails with the following error:

/home/alex/catkin_ws/src/dpgo/tests/testPGO.cpp:120: Failure
Expected: ((ROpt - RTrue).norm()) <= (RMaxError), actual: 2.77197 vs 0.0282838
[  FAILED  ] testDPGO.testRobustSinglePoseAveraging (2 ms)

Empirically, it seems repeat calls to Matrix::Random() within testStiefelProjection produces this error (replacing Matrix::Random() with Matrix::Identity(), for example, seems to indicate this is the case):

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/testUtils.cpp around the testStiefelProjection calls at lines 28 and 32, then inspect tests/testPGO.cpp around line 120. Run testDPGO.testRobustSinglePoseAveraging while increasing the iteration count and compare repeated Matrix::Random() calls with the reported alternatives. Done means the test remains reliable and passes with the expanded coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.