microsoftgraph / microsoftgraph/msgraph-sdk-python

Should we be Pinning dependencies?

Open
#1,106 4 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Needs: Attention :wave: question type:question
Dominant language
Python
Stars
630
Forks
96
Avg merge
15h 20m
Merged PRs (30d)
3

Description

Recently a few issues appeared that are related to dependencies being updated, namely:

  • #1068
  • #1089
  • maybe others, haven't looked

In C# if you install a package it installs the lowest available version that matches (by default). This means if you install the same package next time, you're pretty certain you will get exactly the same dependencies as last time. Back to python, it seems that python does the exact opposite.

Maybe there should be a discussion about whether or not we should start pinning dependencies so you get a more stable installation of a specific version of this sdk. I'm not a python expert and I don't know what is recommended for libraries but it is certainly something to think about.

Any ideas?

https://github.com/microsoftgraph/msgraph-sdk-python/blob/25d6c6c12f6b20a8c6b36f4fa9b7574c1826da0e/pyproject.toml#L13-L21

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the dependency declarations in pyproject.toml at the linked lines, then review issues #1068 and #1089 for the update-related problems. The issue does not define whether or how dependencies should be pinned, so a concrete decision and acceptance criteria are needed before implementation can be considered done.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.