microsoftgraph / microsoftgraph/msgraph-sdk-python-core

Can't deserialize response body from batch request as the json properties are single quoted

未关闭
#807 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

P1 priority:p1 type:bug
主要语言
Python
星标
288
派生
52
平均合并
8 小时 10 分钟
30 天内合并 PR
1

描述

Describe the bug

I'm trying to list applications filtered by particular IDs - there's loads of them so I'm using a batch request with 15 filters at a time (limit). This will allow me to get all the object IDs to query owners etc.

When I attempt to deserialize the BatchResponseContent object with get_response_by_id(response_id, ApplicationCollectionResponse), I get a stack telling me that it can't decode as the properties are single quoted rather than double quoted.

Traceback (most recent call last):
  File "/<project>/.venv/lib/python3.9/site-packages/msgraph_core/requests/batch_response_content.py", line 126, in response_body
    parse_node = ParseNodeFactoryRegistry().get_root_parse_node(
  File "/<project>/.venv/lib/python3.9/site-packages/kiota_abstractions/serialization/parse_node_factory_registry.py", line 41, in get_root_parse_node
    return factory.get_root_parse_node(vendor_specific_content_type, content)
  File "/<project>/.venv/lib/python3.9/site-packages/kiota_abstractions/serialization/parse_node_proxy_factory.py", line 56, in get_root_parse_node
    node = self._concrete.get_root_parse_node(content_type, content)
  File "/<project>/.venv/lib/python3.9/site-packages/kiota_serialization_json/json_parse_node_factory.py", line 37, in get_root_parse_node
    content_dict = json.loads(content_as_str)
  File "/usr/lib/python3.9/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.9/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.9/json/decoder.py", line 353, in raw_decode
    obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 1 column 2 (char 1)

This is backed up by if I just try to do a json_loads(response.body.decode('utf-8')), which then succeeds if I do a .replace("'", '"').

Expected behavior

I should be able to provide the ApplicationCollectionResponse object to BatchResponseContent.get_response_by_id and deserialize the batch response so that I can get the ID out of the response.

How to reproduce
    for app_filter in app_filters:
        app_query_params = (
            ApplicationsRequestBuilder.ApplicationsRequestBuilderGetQueryParameters(
                select=["appId", "id", "serviceManagementReference"],
                filter=f"appId in {app_filter}",
            )
        )
        app_request_config = RequestConfiguration(query_parameters=app_query_params)
        
        batch_request_content.add_request_information(
            client.applications.to_get_request_information(
                request_configuration=app_request_config
            ),
            app_filter,
        )
 
    batch_response = await client.batch.post(batch_request_content)

    if not batch_response or not batch_response.responses:
        log.error("Batch request for application object IDs failed")
        return None

    for response_id in batch_response.responses.keys():
        batch_response.get_response_by_id(response_id, ApplicationCollectionResponse) 
SDK Version

1.17.0 of msgraph-sdk (so 1.2.0 of msgraph-core)

Latest version known to work for scenario above?

No response

Known Workarounds

No response

Debug output
Click to expand log ```
</details>


### Configuration

_No response_

### Other information

_No response_

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 msgraph_core/requests/batch_response_content.py 开始,重点查看 response_body 和 get_response_by_id,并使用所示的批处理请求复现该问题。检查传递给序列化注册表的响应正文,并将其与 JSON 解析器的预期进行比较。当能够从批处理响应中反序列化 ApplicationCollectionResponse 并获取应用程序 ID 时,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
api
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。