microsoftgraph / microsoftgraph/msgraph-sdk-python-core
`LargeFileUploadTask.upload()` throws a 400 error when file size is smaller than max_chunk_size
Personne n'a encore pris cette issue.
- Langage dominant
- Python
- Étoiles
- 288
- Forks
- 52
- Merge moyen
- 8 h 10 min
- PR mergées (30 j)
- 1
Description
Describe the bug
While uploading a large file using LargeFileUploadTask to a SharePoint drive location, if the overall file size is less than the max_chunk_size defined (e.g uploading a 5 KB file but the chunk size is 10 MB), the async LargeFileUploadTask.upload() method uploads the file but throws below error:
APIError:
APIError
Code: 400
message: The server returned an unexpected status code and no error class is registered for this code 400
Expected behavior
The upload task should complete without any errors OR the error message should be meaningful e.g. File is too small.
How to reproduce
destination_path = "path/to/your_file.txt" # path on SharePoint drive where I want to upload the file
file_path = "path/to/your_file.txt" # A small file like 10 KB in my local system
async def upload_large_file(graph_client, drive_id):
try:
file = open(file_path, 'rb')
uploadable_properties = DriveItemUploadableProperties(
additional_data={'@microsoft.graph.conflictBehavior': 'replace'}
)
upload_session_request_body = CreateUploadSessionPostRequestBody(item=uploadable_properties)
print(f"Uploadable Properties: {uploadable_properties.additional_data}")
# can be used for normal drive uploads
try:
upload_session = await graph_client.drives.by_drive_id(
drive_id
).items.by_drive_item_id("root:/my_docs/test_upload.txt:"
).create_upload_session.post(upload_session_request_body)
except APIError as ex:
print(f"Error creating upload session: {ex}")
# to be used for large file uploads
large_file_upload_session = LargeFileUploadSession(
upload_url=upload_session.upload_url,
expiration_date_time=datetime.now() + timedelta(days=1),
additional_data=upload_session.additional_data,
is_cancelled=False,
next_expected_ranges=upload_session.next_expected_ranges
)
max_chunk_size = 10 * 1024 * 1024
task = LargeFileUploadTask(
upload_session=large_file_upload_session,
request_adapter=graph_client.request_adapter,
stream=file,
parsable_factory=DriveItem,
max_chunk_size=max_chunk_size
)
total_length = os.path.getsize(file_path)
# Upload the file
# The callback
def progress_callback(uploaded_byte_range: tuple[int, int]):
print(f"Uploaded {uploaded_byte_range[0]} bytes of {total_length} bytes\n\n")
try:
upload_result = await task.upload(progress_callback)
print(f"Upload complete {upload_result}")
except APIError as ex:
print(f"Error uploading: {ex.message} - {ex.response_status_code}")
raise
except APIError as e:
print(f"Error: {e}")
raise
asyncio.run(upload_large_file(graph_client, drive_id))
SDK Version
1.1.7
Latest version known to work for scenario above?
No response
Known Workarounds
Changing the max_chunk_size value to (file_size - 1) seems to prevent the error from occurring.
Debug output
Click to expand log
```</details>
### Configuration
OS: Windows 10
Architecture: x64
Python version: 3.9.19
### Other information
_No response_
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par LargeFileUploadTask.upload() et reproduisez le cas signalé avec un fichier plus petit que max_chunk_size, par exemple un fichier de 5 Ko avec une taille de chunk de 10 Mo. Suivez le résultat de l’upload et la réponse 400 qui suit ; c’est terminé lorsque l’upload du petit fichier se termine sans erreur inattendue ou signale une erreur explicite.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- python
- Domaine
- api
- Type d'issue
- Bug
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 48/100