microsoftgraph / microsoftgraph/msgraph-sdk-java

LargeFileUpload problem if 1 byte left from last slice

未關閉
#2,581 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

status:waiting-for-triage type:bug
主要語言
Java
星號
444
分支
154
平均合併
18 小時 28 分鐘
30 天內合併 PR
4

描述

Describe the bug

Hello,
i have a problem to upload files if exactly 1 byte is missing in the last slice.

The upload is throwing an exception:
java.util.concurrent.CancellationException: The upload task was retried the maximum number of times without success and has been cancelled.

E.g.
Filesize: 288001

Slice: 32000
Uploaded 32000 bytes of 288001 total bytes
Uploaded 64000 bytes of 288001 total bytes
Uploaded 96000 bytes of 288001 total bytes
Uploaded 128000 bytes of 288001 total bytes
Uploaded 160000 bytes of 288001 total bytes
Uploaded 192000 bytes of 288001 total bytes
Uploaded 224000 bytes of 288001 total bytes
Uploaded 256000 bytes of 288001 total bytes
Uploaded 288000 bytes of 288001 total bytes
-> last one missing

Slice: 16000
Uploaded 16000 bytes of 288001 total bytes
Uploaded 32000 bytes of 288001 total bytes
Uploaded 48000 bytes of 288001 total bytes
Uploaded 64000 bytes of 288001 total bytes
Uploaded 80000 bytes of 288001 total bytes
Uploaded 96000 bytes of 288001 total bytes
Uploaded 112000 bytes of 288001 total bytes
Uploaded 128000 bytes of 288001 total bytes
Uploaded 144000 bytes of 288001 total bytes
Uploaded 160000 bytes of 288001 total bytes
Uploaded 176000 bytes of 288001 total bytes
Uploaded 192000 bytes of 288001 total bytes
Uploaded 208000 bytes of 288001 total bytes
Uploaded 224000 bytes of 288001 total bytes
Uploaded 240000 bytes of 288001 total bytes
Uploaded 256000 bytes of 288001 total bytes
Uploaded 272000 bytes of 288001 total bytes
Uploaded 288000 bytes of 288001 total bytes
-> last one missing

Slice: 64000
Uploaded 64000 bytes of 288001 total bytes
Uploaded 128000 bytes of 288001 total bytes
Uploaded 192000 bytes of 288001 total bytes
Uploaded 256000 bytes of 288001 total bytes
Uploaded 288001 bytes of 288001 total bytes
-> Ok

I created a testfile with filesize 256001

Uploaded 64000 bytes of 256001 total bytes
Uploaded 128000 bytes of 256001 total bytes
Uploaded 192000 bytes of 256001 total bytes
Uploaded 256000 bytes of 256001 total bytes
-> last one missing

Slice: 96000
Uploaded 96000 bytes of 256001 total bytes
Uploaded 192000 bytes of 256001 total bytes
Uploaded 256001 bytes of 256001 total bytes
-> Ok

` CreateUploadSessionPostRequestBody uploadSessionRequest = new CreateUploadSessionPostRequestBody();
DriveItemUploadableProperties properties = new DriveItemUploadableProperties();
properties.getAdditionalData().put("@microsoft.graph.conflictBehavior", "replace");
uploadSessionRequest.setItem(properties);

       UploadSession uploadSession = graphClient
               .drives()
               .byDriveId(driveId)
               .items()
               .byDriveItemId(pfad)
               .createUploadSession()
               .post(uploadSessionRequest);

       // Create the upload task
       int maxSliceSize = 320 * 100;
       LargeFileUploadTask<DriveItem> largeFileUploadTask = new LargeFileUploadTask<>(
               graphClient.getRequestAdapter(),
               uploadSession,
               fileStream,
               streamSize,
               maxSliceSize,
               DriveItem::createFromDiscriminatorValue);

       int maxAttempts = 5;

       // Create a callback used by the upload provider
       IProgressCallback callback = (current, max) -> System.out.println(
               String.format("Uploaded %d bytes of %d total bytes", current, max));

        // Do the upload

       UploadResult<DriveItem> uploadResult = largeFileUploadTask.upload(maxAttempts, callback);
       if (uploadResult.isUploadSuccessful()) {
           logger.info("Upload complete");
           logger.info("Item ID: {}",uploadResult.itemResponse.getId());
       } else {
           logger.info("Upload failed");
       }`
Expected behavior

Upload complete file

How to reproduce

Create a file with filesize = x * maxSliceSize +1

SDK Version

6.62.0

Latest version known to work for scenario above?

No response

Known Workarounds

No response

Debug output
Click to expand log ```

Error Message:
Caused by: java.util.concurrent.CancellationException: The upload task was retried the maximum number of times without success and has been cancelled.
at com.microsoft.graph.core.tasks.LargeFileUploadTask.upload(LargeFileUploadTask.java:149)

</details>


### Configuration

 Linux
Java 8
x64

### Other information

_No response_

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

從 LargeFileUploadTask.java:149 中識別的 com.microsoft.graph.core.tasks.LargeFileUploadTask.upload 開始,使用大小為 x * maxSliceSize + 1 的檔案重現失敗。追蹤最後一個位元組切片的處理方式,並驗證上傳能在未取消的情況下成功完成。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
java
領域
api
Issue 類型
缺陷
難度
3/5
預估耗時
1-2 天
活躍度
冷清
描述清晰度
基本清楚
新手友好度
68/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。