microsoftgraph / microsoftgraph/msgraph-sdk-java

null batchResponse when POSTing a batch request.

Ouverte
#2,255 3 commentaires 0 réactions 1 personne assignée Voir sur GitHub

@Ndiritu y travaille déjà.

Depuis le 19/12/2024.

type:bug
Langage dominant
Java
Étoiles
444
Forks
154
Merge moyen
18 h 28 min
PR mergées (30 j)
4

Description

Describe the bug
Caused by: java.lang.NullPointerException: The following parameter cannot be null: batchResponse
	at java.base/java.util.Objects.requireNonNull(Objects.java:259) ~[?:?]
	at com.microsoft.graph.core.content.BatchResponseContent.<init>(BatchResponseContent.java:42) ~[microsoft-graph-core-3.2.1.jar:?]
	at com.microsoft.graph.core.requests.BatchRequestBuilder.post(BatchRequestBuilder.java:53) ~[microsoft-graph-core-3.2.1.jar:?]
	at com.microsoft.graph.serviceclient.CustomBatchRequestBuilder.post(CustomBatchRequestBuilder.java:41) ~[microsoft-graph-6.16.0.jar:?]
	at com.microsoft.graph.core.requests.BatchRequestBuilder.post(BatchRequestBuilder.java:67) ~[microsoft-graph-core-3.2.1.jar:?]
	at com.microsoft.graph.serviceclient.CustomBatchRequestBuilder.post(CustomBatchRequestBuilder.java:53) ~[microsoft-graph-6.16.0.jar:?]
2024-11-21T16:05:58 WARNING [TOMCAT] okhttp3.internal.platform.Platform log okhttp3.OkHttpClient - A connection to https://graph.microsoft.com/ was leaked. Did you forget to close a response body? To see where this was allocated, set the OkHttpClient logger level to FINE: Logger.getLogger(OkHttpClient.class.getName()).setLevel(Level.FINE);

Our code started throwing a null pointer exception as shown in the logs. The code and requests normally run fine, however this error seems to have randomly occurred. Once we saw this error all subsequent requests to Azure also failed until the process was restarted.

Under what circumstances could this happen?

Expected behavior

Requests complete successfully. Failed requests should throw an ApiException?

How to reproduce

This does not occur under normal circumstances - the following code usually works fine.

We have seen the same error on two different underlying requests, wrapped in batch requests.
mGraphClient.users().byUserId(x).memberOf().graphGroup() and mGraphClient.groups().getByIds()

An example:

ClientSecretCredential vCredential = new ClientSecretCredentialBuilder().clientId(mClientId).tenantId(mTenantId).clientSecret(mClientSecret).build();
mGraphClient = new GraphServiceClient(vCredential, "https://graph.microsoft.com/.default");

-----
BatchRequestContentCollection vBatchRequest = new BatchRequestContentCollection(mGraphClient);
for (String vId : pIds) {
  RequestInformation vRequestInfo = mGraphClient.users().byUserId(vId).memberOf().graphGroup().toGetRequestInformation(requestConfiguration -> {
	  requestConfiguration.queryParameters.select = new String[] { ID };
	  requestConfiguration.queryParameters.top = MAX_PAGE_SIZE;
  });
  vBatchRequest.addBatchRequestStep(vRequestInfo);
}

BatchResponseContentCollection vBatchResponse = mGraphClient.getBatchRequestBuilder().post(vBatchRequest, null);
SDK Version

6.16.0

Latest version known to work for scenario above?

No response

Known Workarounds

No response

Debug output
Click to expand log ```
</details>


### Configuration

_No response_

### Other information

_No response_

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.