microsoftgraph / microsoftgraph/msgraph-sdk-java

Improve default RetryHandler implementation

Open
#2,186 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Needs: Attention :wave: type:enhancement type:legacy-version
Dominant language
Java
Stars
444
Forks
154
Avg merge
18h 28m
Merged PRs (30d)
4

Description

Is your feature request related to a problem? Please describe the problem.

SDK V5
As per incident: 2409111420000033
in case there is a low memory on server side the server returns 503 for other error codes.

In such cases SDK treats 404, 403 errors as if it is 503 and retries.

We were instructed by Microsoft support person of contact to implement RetryHandler on application side and retry only if "retry-after" header is present. However, it sounds like this should be handled in SDK side rather than us.

Describe the solution you'd like.

I would propose such cases, when Microsoft servers have low memory to be handled by SDK

Additional context?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name a source file or test; start by locating the default RetryHandler implementation and its existing retry tests in the Java SDK. Check how 403, 404, 503, and the retry-after header are handled, then add coverage showing that retries occur only when the requested response header permits them.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.