microsoftgraph / microsoftgraph/msgraph-beta-sdk-python

Missing Enumeration in class DeviceManagementConfigurationWindowsSkus

未關閉 適合新手
#376 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

enhancement
主要語言
Python
星號
44
分支
16
平均合併
20 小時 39 分鐘
30 天內合併 PR
3

描述

Is your feature request related to a problem? Please describe.

graph.get_configuration_settings_for_definition(setting_instance_template.setting_definition_id) returns an error

In the graph API expolorer it returns values that are not in the DeviceManagementConfigurationWIndowsSkus

{
    "@odata.context": "https://graph.microsoft.com/beta/$metadata#deviceManagement/configurationSettings",
    "@microsoft.graph.tips": "Use $select to choose only the properties your app needs, as this can lead to performance improvements. For example: GET deviceManagement/configurationSettings?$select=accessTypes,applicability",
    "value": [
        {
            "@odata.type": "#microsoft.graph.deviceManagementConfigurationChoiceSettingDefinition",
            "accessTypes": "add,delete,get,replace",
            "keywords": [
                "DeviceInstall_IDs_Deny",
                "Prevent installation of devices that match any of these device IDs",
                "\\System\\Device Installation\\Device Installation Restrictions",
                "Device Installation Restrictions"
            ],
            "infoUrls": [
                "https://docs.microsoft.com/en-us/windows/client-management/mdm/policy-csp-deviceinstallation"
            ],
            "baseUri": "./Device/Vendor/MSFT/Policy",
            "offsetUri": "/Config/DeviceInstallation/PreventInstallationOfMatchingDeviceIDs",
            "rootDefinitionId": "device_vendor_msft_policy_config_deviceinstallation_preventinstallationofmatchingdeviceids",
            "categoryId": "979412d7-6716-440c-9a64-5889026d73da",
            "settingUsage": "configuration",
            "uxBehavior": "toggle",
            "visibility": "settingsCatalog,template",
            "id": "device_vendor_msft_policy_config_deviceinstallation_preventinstallationofmatchingdeviceids",
            "description": "This policy setting allows you to specify a list of Plug and Play hardware IDs and compatible IDs for devices that Windows is prevented from installing. This policy setting takes precedence over any other policy setting that allows Windows to install a device.If you enable this policy setting, Windows is prevented from installing a device whose hardware ID or compatible ID appears in the list you create. If you enable this policy setting on a remote desktop server, the policy setting affects redirection of the specified devices from a remote desktop client to the remote desktop server.If you disable or do not configure this policy setting, devices can be installed and updated as allowed or prevented by other policy settings.",
            "helpText": "",
            "name": "DeviceInstall_IDs_Deny",
            "displayName": "Prevent installation of devices that match any of these device IDs",
            "version": "638472449890445475",
            "defaultOptionId": "device_vendor_msft_policy_config_deviceinstallation_preventinstallationofmatchingdeviceids_0",
            "applicability": {
                "@odata.type": "#microsoft.graph.deviceManagementConfigurationWindowsSettingApplicability",
                "description": null,
                "platform": "windows10",
                "deviceMode": "none",
                "technologies": "mdm,configManager,microsoftSense",
                "configurationServiceProviderVersion": "5.0",
                "maximumSupportedVersion": null,
                "minimumSupportedVersion": "10.0.15063",
                "windowsSkus": [
                    "windowsEnterprise",
                    "windowsProfessional",
                    "windowsEducation",
                    "iotEnterprise",
                    **"windowsCloudN",
                    "windows11SE",
                    "iotEnterpriseSEval"**
                ],
                "requiresAzureAd": false,
                "requiredAzureAdTrustType": "none"
            },
            "occurrence": {
                "minDeviceOccurrence": 0,
                "maxDeviceOccurrence": 1
            },
            "referredSettingInformationList": [],
            "options": [
                {
                    "itemId": "device_vendor_msft_policy_config_deviceinstallation_preventinstallationofmatchingdeviceids_0",
                    "description": null,
                    "helpText": null,
                    "name": "Disabled",
                    "displayName": "Disabled",
                    "optionValue": {
                        "@odata.type": "#microsoft.graph.deviceManagementConfigurationIntegerSettingValue",
                        "settingValueTemplateReference": null,
                        "value": 0
                    },
                    "dependentOn": [],
                    "dependedOnBy": []
                },
                {
                    "itemId": "device_vendor_msft_policy_config_deviceinstallation_preventinstallationofmatchingdeviceids_1",
                    "description": null,
                    "helpText": null,
                    "name": "Enabled",
                    "displayName": "Enabled",
                    "optionValue": {
                        "@odata.type": "#microsoft.graph.deviceManagementConfigurationIntegerSettingValue",
                        "settingValueTemplateReference": null,
                        "value": 1
                    },
                    "dependentOn": [],
                    "dependedOnBy": [
                        {
                            "dependedOnBy": "device_vendor_msft_policy_config_deviceinstallation_preventinstallationofmatchingdeviceids_deviceinstall_ids_deny_list",
                            "required": true
                        },
                        {
                            "dependedOnBy": "device_vendor_msft_policy_config_deviceinstallation_preventinstallationofmatchingdeviceids_deviceinstall_ids_deny_retroactive",
                            "required": true
                        }
                    ]
                }
            ]
        }
    ]
}

Describe the solution you'd like
A clear and concise description of what you want to happen.

Add

    WindowsCloudN = "windowsCloudN"
    Windows11SE = "Windows11SE",
    IotEnterpriseSEval = "iotEnterpriseSEval"

Describe alternatives you've considered
I tried only asking for the other fields besides applicability, but the field that I needed "options" is in the object :(

Additional context
I just wanted the options value for the setting, but since that wasn't in the object, adding the 3 values to the enum was the fastes way to fix this.

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

在 Python SDK 中找到 DeviceManagementConfigurationWindowsSkus 類別,並閱讀其現有的 enum 成員以及附近的測試(如果有)。新增 issue 中要求的三個 Windows SKU 值,然後執行相關的 enum 或 SDK 測試;當 Graph API 範例回傳的所有值都可以表示時,即視為完成。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
python
領域
api
Issue 類型
功能
難度
1/5
預估耗時
1 小時以內
活躍度
停滯
描述清晰度
描述清楚
新手友好度
72/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。