microsoft / microsoft/vscode

Refactor extension proposals check to use Array.prototype.includes

Open
#334,653 0 comments 0 reactions 1 assignee Claimed by @dbaeumer View on GitHub
stale triage-needed
Dominant language
TypeScript
Stars
193k
Forks
42.4k
PR merge metrics
PR metrics pending

Description

**Problem/Feature Description**
In the extension proposal utility, the code currently uses `existing.indexOf(e.id) === -1` to filter known extensions.

**Proposed Solution**
Replace `existing.indexOf(e.id) === -1` with modern TypeScript/JavaScript syntax using `!existing.includes(e.id)` to improve code readability and maintainability.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.