microsoft / microsoft/vscode-python-environments

Consider activating the environment without environment variables

未關閉
#241 0 則留言 0 個 reaction 已指派 1 人 在 GitHub 檢視

還沒有人認領這個 Issue。

area-activation area-terminal feature-request
主要語言
TypeScript
星號
138
分支
62
平均合併
1 天 4 小時
30 天內合併 PR
35

描述

Testing #226

Related https://github.com/microsoft/vscode-python-environments/issues/240?reload=1

The way I was envisioning this working was something like this:

  1. Create a symlink in the user data dir for each shell that points at the vscode-python directory
  • Every update, this symlink is replaced
  • We would own this file and don't need to ask the user to create it
  1. Upon opting in to shellStartup, either via manual or as the default UX with a dialog (https://github.com/microsoft/vscode-python-environments/issues/232?reload=1). Add code to each shell script that sources symlink
  2. Upon opening a window (maybe other events?), verify the symlinks

Using this approach, the shell scripts can be smarter than just a simple source script and we don't need to pollute the environment (https://github.com/microsoft/vscode-python-environments/issues/240?reload=1). They can also be as verbose as we want it to be and we can keep the calling of the script quite concise since things like exiting when TERM_PROGRAM!=vscode can be inside this script that is a living file and can be changes as we improve the activation logic (https://github.com/microsoft/vscode-python-environments/issues/234?reload=1).

Other thoughts:

  • To prevent double activation, you could add an environment variable that declares it was activated. Maybe $SHLVL is useful here?
  • No environment changes means no more ⚠ icons related to python environments
  • We could make it be safe to assume this would only activate when opening a terminal inside VS Code and not sub-shells, so the cwd can be used as the root of the repo to activate
  • The change in scripts can be very concise and clear, like a line with a comment followed by a line to source the file, since we can and want to move conditions into the script.

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。