microsoft / microsoft/vscode-python-environments
Leverage execution.exitCode for execution promise resolve
未关闭
@anthonykim1 已经在做这个了。
开始于 2025年2月7日。
debt
needs PR
- 主要语言
- TypeScript
- 星标
- 138
- 派生
- 62
- 平均合并
- 1 天 4 小时
- 30 天内合并 PR
- 35
描述
https://github.com/microsoft/vscode-python-environments/pull/160#discussion_r1946083357
We have
let timer: NodeJS.Timeout | undefined = setTimeout(() => {
execPromise.resolve();
traceError(`Shell execution timed out: ${command.executable} ${command.args?.join(' ')}`);
}, 2000);
in src/features/terminal/terminalActivationState.ts
We could do a Promise race where we resolve faster, via listening to .onDidEndTerminalShellExecution and watching if exitCode returned with values other than undefined.
Also we should watch for exitCode regardless to ensure if command failed/succeeded. (For example, in the middle of the activation, what if user interrupted and stopped? We should know this)
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。