microsoft / microsoft/vscode-python-environments

Leverage execution.exitCode for execution promise resolve

Open
#169 0 comments 0 reactions 1 assignee Claimed by @anthonykim1 View on GitHub
debt needs PR
Dominant language
TypeScript
Stars
138
Forks
62
Avg merge
1d 4h
Merged PRs (30d)
35

Description

https://github.com/microsoft/vscode-python-environments/pull/160#discussion_r1946083357

We have
```
let timer: NodeJS.Timeout | undefined = setTimeout(() => {
execPromise.resolve();
traceError(`Shell execution timed out: ${command.executable} ${command.args?.join(' ')}`);
}, 2000);
```
in src/features/terminal/terminalActivationState.ts

We could do a Promise race where we resolve faster, via listening to `.onDidEndTerminalShellExecution` and watching if exitCode returned with values other than `undefined`.

Also we should watch for exitCode regardless to ensure if command failed/succeeded. (For example, in the middle of the activation, what if user interrupted and stopped? We should know this)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.