microsoft / microsoft/vscode-pull-request-github

Request for `>GitHub Pull Requests: Forget Pull Request`

Offen
#8,639 1 Kommentar 4 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Vorherrschende Sprache
TypeScript
Sterne
2.6k
Forks
795
Ø Merge
1 T. 4 Std.
Gemergte PRs (30 T.)
46

Beschreibung

When I create a pull request, my workflow is typically:

  • Create a branch, feature/foo
  • Do work
  • Create a pull request associated with feature/foo
  • Get a review from a colleague
  • Look at the review on GitHub
  • Merge the pull request from GitHub

This leaves my local state in an awkward scenario. I need to:

  • Switch to main
  • Pull main
  • Delete my feature/foo branch

I can do this manually, but this is such a common workflow of mine that I feel like a command for this is somehow missing. In R, we've created a suite of PR related helpers for this and the relevant one is usethis::pr_finish(), which does these exact steps.

The closest I can seem to get is:

  • >GitHub Pull Requests: Checkout Default Branch
  • With "githubPullRequests.postDone": "checkoutDefaultBranchAndPull"

(I'm not even 100% sure that a pull occurs when you use the command, but I think it does)

This accomplishes the first 2 bullets, but not the 3rd, so I have to go delete feature/foo myself.

I think I am missing something like

>GitHub Pull Requests: Forget Pull Request

Which has the purpose of:

  • Checkout the default branch (subject to githubPullRequests.postDone so I can make it also pull)
  • Delete the current branch you switched from

I would use this all the time if it existed as a way to cleanup after a merge via the GitHub UI.


I am aware of "githubPullRequests.deleteBranchAfterMerge": true. I do not believe that solves my problem because I almost exclusively merge via the GitHub UI, and it only works if I merge via the Extension UI.


It's also worth noting that if I checkout someone else's PR to perform a review, then it mostly works as I expect.

  • Checkout colleague PR feature/bar using the GitHub Pull Request extension
  • Leave my review
  • Click Checkout Default Branch (with "githubPullRequests.postDone": "checkoutDefaultBranchAndPull" set)
  • This auto deletes feature/bar for me

This workflow is quite nice! I want something similar for finishing off my own PRs.

Here is a video of me doing that workflow, which I do like:

https://github.com/user-attachments/assets/ff6a07e6-7ae5-4d8b-a447-91d51c96b597

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne damit, den bestehenden Befehl Checkout Default Branch sowie die Einstellungen githubPullRequests.postDone und githubPullRequests.deleteBranchAfterMerge nachzuverfolgen. Das Feature ist abgeschlossen, wenn ein gemergter Pull Request zum Default Branch zurückkehren, das konfigurierte Pull-Verhalten anwenden und den zuvor ausgecheckten Branch löschen kann.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
git, github, typescript
Bereich
developer-experience, tooling
Issue-Typ
Feature
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Ruhig
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
58/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.