microsoft / microsoft/vscode-pull-request-github
Selecting `Approved` from the dropdown should not auto submit
还没有人认领这个 Issue。
- 主要语言
- TypeScript
- 星标
- 2.6k
- 派生
- 796
- 平均合并
- 1 天 4 小时
- 30 天内合并 PR
- 46
描述
Duplicate of https://github.com/microsoft/vscode-pull-request-github/issues/5300
Duplicate of https://github.com/microsoft/vscode-pull-request-github/issues/7028
I'd like to once again bring this issue up, because using a drop down to submit an action feels very unprecedented to me.
Like those other issues, I expect that hitting Approve here will change the blue Comment box from saying Comment to Approve, but will not submit the PR approval yet.
To me that feels like a 1:1 mapping of the behavior of switching to the Approve radio button. Just clicking that radio button does not auto submit the PR.
I often know I'm going to approve the PR, but haven't written my final approval comments in the box yet. On the github UI I'll change the radio button then go back and fill in the comments. I can't do this from the vs code extension and I end up double submitting so often 😢 .
I do like that if you widen the sidebar, then you see the 3 options inline in blue box form
If you are unwilling to make the drop down be a pure "switcher", then at the very least if you could please style this drop down the same as the Create Merge Commit drop down, I think that would resolve a lot of my confusion.
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
未指定文件或测试。请从 pull request review action dropdown 入手,将其行为和样式与 Create Merge Commit dropdown 进行比较;完成的标准是选择 Approve 会更改 review action 但不会提交,从而可以先输入评论。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- typescript
- 领域
- frontend
- Issue 类型
- 功能
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100