microsoft / microsoft/vscode-pull-request-github
Comments attached to wrong lines
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.6k
- Forks
- 795
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 46
Description
- Extension version: 0.124.1
- VSCode Version: 1.107.1
- OS: Fedora 42
- Repository Clone Configuration (single repository/fork of an upstream repository): fork of an upstream repo
- GitHub Product (GitHub.com/GitHub Enterprise version x.x.x): GitHub.com
See here for the affected PR and the comment: https://github.com/scylladb/scylladb/pull/27386/files#r2643211612
When viewing with a browser, the comment is in the right place, right where there are 7 lines removed and the one below:
for shard in iterate_over_describe_stream(dynamodbstreams, arn, time.time() + 60):
is added instead.
In VS Code the comment is shown associated to the wrong lines - to the new lines starting from 1409, not the old lines starting from 1409.
Steps to Reproduce:
- Install the "GitHub Pull Requests" extension to VS Code.
- View the affected PR in VS Code.
- Search for a string from the comment to see it in VS Code
The right placement when viewed with Chromium:
The wrong placement when viewed in VS Code:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the misplaced comment in the GitHub Pull Requests extension by opening PR #27386 in VS Code and searching for the comment text. Compare the extension's placement with the Chromium view, and consider the issue complete when the comment is attached to the removed lines rather than the new lines beginning at 1409.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100