microsoft / microsoft/vscode-pull-request-github

In progress comments are lost when updating after PR is merged

Open
#7,556 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
2.6k
Forks
796
Avg merge
1d 4h
Merged PRs (30d)
46

Description

  • Extension version: 0.116.0
  • VSCode Version: 1.103.0
  • OS: Darwin arm64 24.5.0
  • Repository Clone Configuration (single repository/fork of an upstream repository): single repository
  • GitHub Product (GitHub.com/GitHub Enterprise version x.x.x): GitHub.com

Steps to Reproduce:

  1. Start adding a review comment to a PR but don't save the comment.
  2. Merge the PR.

When the PR state refreshes the comment field is closed and the comment is lost. However any pending submitted comments are still available and can be submitted.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by reproducing the review-comment flow in VS Code with the listed extension and VS Code versions, then trace what happens to an unsaved comment when the PR is merged and its state refreshes. Done means the draft remains available after refresh, while pending submitted comments can still be submitted.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, typescript
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.