microsoft / microsoft/vscode-java-debug
Optimize the search logic for launch.json
Open
Nobody has claimed this yet.
ai-triaged
debt
enhancement
- Dominant language
- TypeScript
- Stars
- 591
- Forks
- 429
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 19
Description
See https://github.com/microsoft/vscode-java-debug/pull/1234/files#r1010024710.
We have some code to search a launch.json file via await vscode.workspace.findFiles(".vscode/launch.json", "**/node_modules/**");, it can be optimized by specifying the workspace folder and maxResult as 1.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the vscode.workspace.findFiles call described in the issue and review the linked pull request discussion for its context. Update the search to use the workspace folder and a maximum result count of 1, then verify that launch.json discovery still returns the intended file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- devtools
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100