If we fail to open the settings file, display a message if it existed

Open
#1,328 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
desktop

Research direction

Start by reading the related issue #1325 and tracing how Windows Terminal opens the settings file. Confirm the existing-file/open-failure case is distinguished from a missing file, then ensure an error dialog is shown and the user's settings are not replaced with defaults.

Written by the indexing model from the issue text.

Description

Area-UserInterface Issue-Task Product-Terminal

A follow up from #1325.

In #1325's case, the file did exist, but we failed to open it. In this case, we should display some sort of error dialog to the user, instead of blowing away the user settings with the defaults.

Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/terminal

All issues in microsoft/terminal

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.