microsoft / microsoft/durabletask-java

Apply DurableHttpRequest.HttpRetryOptions when scheduling durable HTTP retries

Aperta
#303 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Needs: Triage :mag:
Lingua principale
Java
Stelle
29
Fork
18
Merge medio
1g 10h
PR unite (30g)
2

Descrizione

HttpRetryOptions is exposed on DurableHttpRequest, but DurableHttp.callHttp does not use that configuration to schedule retries unless the caller separately supplies TaskOptions. This is the Java retry-scheduling follow-up to Azure/azure-functions-durable-extension#1984, not a request to add a second HTTP API or retry-options type.

Current behavior

Checked v1.9.0 and main at cfdfbf505ed0c4b1b5e9d39a55504650f1dd09e8:

  • HttpRetryOptions exposes intervals, maximum attempts, backoff, retry timeout, and status-code selection.
  • DurableHttpRequest serializes those options under retryOptions for the HTTP activity.
  • DurableHttp.callHttp(ctx, request) delegates with null TaskOptions. The implementation then calls ctx.callActivity without a retry policy; it does not derive one from request.getHttpRetryOptions().
  • The extension's HTTP activity uses the configured status codes to turn matching responses into failures, but durable retry scheduling is separate from that failure classification.

Consequently, the code path for setting only the request's HttpRetryOptions does not schedule the configured retry attempts. Supplying a separate TaskOptions/RetryPolicy can schedule retries, but duplicates configuration and leaves the request-level attempt/backoff settings unapplied.

This finding is based on source-path inspection; an end-to-end failure/retry reproduction has not been executed.

Reproduction scenario

  1. Configure a DurableHttpRequest with HttpRetryOptions specifying three attempts and HTTP 503 as retryable.
  2. Call ctx.callHttp(request) without separate TaskOptions.
  3. Use an endpoint that returns 503 for the first attempt and 200 for the next attempt.
  4. Verify whether the orchestration schedules the second request using the request's retry policy rather than failing after the first HTTP activity.

Acceptance Criteria

  • Apply the request's HttpRetryOptions to durable retry scheduling when no explicit scheduling override is supplied.
  • Honor attempt limits, first/max intervals, backoff, and retry timeout, while retaining HTTP-status-code filtering.
  • Define and document precedence when explicit TaskOptions and request-level HTTP retry options are both supplied.
  • Preserve existing behavior when retry options are omitted.
  • Add coverage for request-only retry configuration, retry-then-success, exhaustion, excluded status codes, transport failures, and explicit TaskOptions interaction.
  • Update API documentation/examples so callers do not need two inconsistent policies for one HTTP request.

Related

  • Original cross-language tracker: Azure/azure-functions-durable-extension#1984.
  • Existing broad HTTP support tracker: microsoft/durabletask-java#39.
  • HTTP API implementation: microsoft/durabletask-java#271.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia da DurableHttp.callHttp e traccia il modo in cui DurableHttpRequest.getHttpRetryOptions viene passato a ctx.callActivity, quindi esamina HttpRetryOptions e il comportamento dei tentativi di nuovo di TaskOptions. Definisci la precedenza per i TaskOptions espliciti, mantieni il filtraggio in base al codice di stato e aggiungi una copertura per i tentativi di nuovo solo della richiesta, il successo, l’esaurimento, le esclusioni, gli errori di trasporto e i casi di interazione. Aggiorna la documentazione dell’API o gli esempi quando il comportamento sarà definito.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
java
Ambito
api, backend, distributed-systems, documentation, testing
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
48/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.