microsoft / microsoft/TypeScript

Proposal: Type Builder API

Abierto
#9,883 5 comentarios 40 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Awaiting More Feedback Suggestion
Lenguaje dominante
Go
Estrellas
111k
Forks
14.3k
Merge medio
2 d 4 h
PR fusionados (30 d)
132

Descripción

Alongside the relationship API proposed in #9879, it would be very useful to expose an API to programatically build types - this is useful for making comparisons between a build-in type, and a type structure which isn't a part of the original compilation (lint rules, language service extensions, and external tools could find this a very useful API surface, and this is almost a prerequisite for a type provider-like feature). I have a protototype here, and the new API surface (excluding anything covered by #9879) looks like this:

interface TypeChecker {
  getTypeBuilder(): TypeBuilder;
}

interface TypeBuilder {
    startEnumType(): EnumTypeBuilder<Type>;
    startClassType(): ClassTypeBuilder<Type>;
    startInterfaceType(): InterfaceTypeBuilder<Type>;
    startTupleType(): TupleTypeBuilder<Type>;
    startUnionType(): UnionTypeBuilder<Type>;
    startIntersectionType(): IntersectionTypeBuilder<Type>;
    startAnonymousType(): AnonymousTypeBuilder<Type>;
    startNamespace(): NamespaceBuilder<Symbol>;
    startSignature(): SignatureBuilder<Signature>;

    // create an unbound type parameter, optionally with a constraint, for use in generic creation
    createTypeParameter(name: string, constraint?: Lazy<Type>): TypeParameter;
    // Useful for constructing reusable generics in your structures - probably need to make the params/type lazy
    createTypeAlias(name: string, params: TypeParameter[], type: Type): Symbol;
    // This way consumers can fill out generics - probably need to make the type/type arguments lazy
    getTypeReferenceFor(type: GenericType, ...typeArguments: Type[]): TypeReference;
    // Unsure about this one. Maybe there's a better way to make programmatic clodules and such? 
    mergeSymbols(symbolA: Symbol, symbolB: Symbol): void;
}

const enum BuilderMemberModifierFlags {
    None        = 0,
    Public      = 1 << 0,
    Protected   = 1 << 1,
    Private     = 1 << 2,
    Readonly    = 1 << 3
}

namespace TypeBuilderKind {
    export type Namespace = "Namespace";
    export const Namespace: Namespace = "Namespace";

    export type Signature = "Signature";
    export const Signature: Signature = "Signature";

    export type Anonymous = "Anonymous";
    export const Anonymous: Anonymous = "Anonymous";

    export type Interface = "Interface";
    export const Interface: Interface = "Interface";

    export type Class = "Class";
    export const Class: Class = "Class";

    export type Tuple = "Tuple";
    export const Tuple: Tuple = "Tuple";

    export type Union = "Union";
    export const Union: Union = "Union";

    export type Intersection = "Intersection";
    export const Intersection: Intersection = "Intersection";

    export type Enum = "Enum";
    export const Enum: Enum = "Enum";
}
type TypeBuilderKind = TypeBuilderKind.Namespace
    | TypeBuilderKind.Signature
    | TypeBuilderKind.Anonymous
    | TypeBuilderKind.Interface
    | TypeBuilderKind.Class
    | TypeBuilderKind.Tuple
    | TypeBuilderKind.Union
    | TypeBuilderKind.Intersection
    | TypeBuilderKind.Enum;

type Lazy<T> = T | (() => T);

interface BaseTypeBuilder<FinishReturnType> {
    finish(): FinishReturnType;
}

interface EnumTypeBuilder<FinishReturnType> extends BaseTypeBuilder<FinishReturnType> {
    addMember(name: string, value: number): this;
    addMember(name: string): this;
    isConst(flag: boolean): this;
    setName(name: string): this;
}

interface StructuredTypeBuilder<FinishReturnType> extends BaseTypeBuilder<FinishReturnType> {
    addMember(name: string, flags: BuilderMemberModifierFlags, type: Lazy<Type>): this;
    buildMember(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Enum): EnumTypeBuilder<this>;
    buildMember(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildMember(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildMember(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Tuple): TupleTypeBuilder<this>;
    buildMember(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;
    buildMember(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildMember(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildMember(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Namespace): NamespaceBuilder<this>;
    buildMember(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Signature): SignatureBuilder<this>;
}

interface ClassTypeBuilder<FinishReturnType> extends StructuredTypeBuilder<FinishReturnType>, TypeParameterBuilder {
    setName(name: string): this;

    setBaseType(type: Lazy<Type>): this;
    buildBaseType(kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildBaseType(kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildBaseType(kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildBaseType(kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildBaseType(kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;

    addImplementsType(type: Lazy<Type>): this;
    buildImplementsType(kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildImplementsType(kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildImplementsType(kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildImplementsType(kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildImplementsType(kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;

    addStatic(name: string, flags: BuilderMemberModifierFlags, type: Lazy<Type>): this;
    buildStatic(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildStatic(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildStatic(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Tuple): TupleTypeBuilder<this>;
    buildStatic(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;
    buildStatic(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildStatic(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildStatic(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Signature): SignatureBuilder<this>;
    // buildStatic(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Enum): EnumTypeBuilder<this>;
    // buildStatic(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Namespace): NamespaceBuilder<this>;

    addConstructSignature(sig: Lazy<Signature>): this;
    buildConstructSignature(): SignatureBuilder<this>;
}

interface ObjectTypeBuilder<FinishReturnType> extends BaseTypeBuilder<FinishReturnType> {
    addCallSignature(sig: Lazy<Signature>): this;
    buildCallSignature(): SignatureBuilder<this>;

    addConstructSignature(sig: Lazy<Signature>): this;
    buildConstructSignature(): SignatureBuilder<this>;

    addStringIndexType(name: string, flags: BuilderMemberModifierFlags, type: Lazy<Type>): this;
    buildStringIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildStringIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildStringIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Tuple): TupleTypeBuilder<this>;
    buildStringIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;
    buildStringIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildStringIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildStringIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Signature): SignatureBuilder<this>;

    addNumberIndexType(name: string, flags: BuilderMemberModifierFlags, type: Lazy<Type>): this;
    buildNumberIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildNumberIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildNumberIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Tuple): TupleTypeBuilder<this>;
    buildNumberIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;
    buildNumberIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildNumberIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildNumberIndexType(name: string, flags: BuilderMemberModifierFlags, kind: TypeBuilderKind.Signature): SignatureBuilder<this>;
}

interface TypeParameterBuilder {
    // This overload is useful for making a TypeParameter yourself and threading it back in (as a type)
    // elsewhere in order to flow generics through a generated type
    addTypeParameter(type: Lazy<TypeParameter>): this;
    addTypeParameter(name: string, constraint?: Lazy<Type>): this;
    buildTypeParameter(name: string, kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildTypeParameter(name: string, kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildTypeParameter(name: string, kind: TypeBuilderKind.Tuple): TupleTypeBuilder<this>;
    buildTypeParameter(name: string, kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;
    buildTypeParameter(name: string, kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildTypeParameter(name: string, kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildTypeParameter(name: string, kind: TypeBuilderKind.Signature): SignatureBuilder<this>;
}

interface InterfaceTypeBuilder<FinishReturnType> extends ObjectTypeBuilder<FinishReturnType>, TypeParameterBuilder, StructuredTypeBuilder<FinishReturnType> {
    setName(name: string): this;

    addBaseType(type: Lazy<Type>): this;
    buildBaseType(kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildBaseType(kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
}

interface CollectionTypeBuilder<FinishReturnType> extends BaseTypeBuilder<FinishReturnType> {
    addType(type: Lazy<Type>): this;
    // buildMemberType(kind: TypeBuilderKind.Namespace): NamespaceBuilder<this>;
    // buildMemberType(kind: TypeBuilderKind.Enum): EnumTypeBuilder<this>;
    buildMemberType(kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildMemberType(kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildMemberType(kind: TypeBuilderKind.Tuple): TupleTypeBuilder<this>;
    buildMemberType(kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;
    buildMemberType(kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildMemberType(kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildMemberType(kind: TypeBuilderKind.Signature): SignatureBuilder<this>;
}

interface TupleTypeBuilder<FinishReturnType> extends CollectionTypeBuilder<FinishReturnType> {}
export interface UnionTypeBuilder<FinishReturnType> extends CollectionTypeBuilder<FinishReturnType> {}
export interface IntersectionTypeBuilder<FinishReturnType> extends CollectionTypeBuilder<FinishReturnType> {}
export interface AnonymousTypeBuilder<FinishReturnType> extends ObjectTypeBuilder<FinishReturnType> {
    addMember(name: string, type: Lazy<Type>): this;
    buildMember(name: string, kind: TypeBuilderKind.Enum): EnumTypeBuilder<this>;
    buildMember(name: string, kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildMember(name: string, kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildMember(name: string, kind: TypeBuilderKind.Tuple): TupleTypeBuilder<this>;
    buildMember(name: string, kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;
    buildMember(name: string, kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildMember(name: string, kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildMember(name: string, kind: TypeBuilderKind.Namespace): NamespaceBuilder<this>;
    buildMember(name: string, kind: TypeBuilderKind.Signature): SignatureBuilder<this>;
}

interface NamespaceBuilder<FinishReturnType> extends BaseTypeBuilder<FinishReturnType> {
    setName(name: string): this;

    addExport(symbol: Lazy<Symbol>): this;
    addExport(name: string, type: Lazy<Type>): this;
    buildExport(name: string, kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildExport(name: string, kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildExport(name: string, kind: TypeBuilderKind.Tuple): TupleTypeBuilder<this>;
    buildExport(name: string, kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;
    buildExport(name: string, kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildExport(name: string, kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildExport(name: string, kind: TypeBuilderKind.Signature): SignatureBuilder<this>;
    buildExport(name: string, kind: TypeBuilderKind.Enum): EnumTypeBuilder<this>;
    buildExport(name: string, kind: TypeBuilderKind.Namespace): NamespaceBuilder<this>;
}
interface SignatureBuilder<FinishReturnType> extends BaseTypeBuilder<FinishReturnType>, TypeParameterBuilder {
    setName(name: string): this;
    setConstructor(flag: boolean): this;

    addParameter(name: string, type: Lazy<Type>): this;
    buildParameter(name: string, kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildParameter(name: string, kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildParameter(name: string, kind: TypeBuilderKind.Tuple): TupleTypeBuilder<this>;
    buildParameter(name: string, kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;
    buildParameter(name: string, kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildParameter(name: string, kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildParameter(name: string, kind: TypeBuilderKind.Signature): SignatureBuilder<this>;

    setRestParameter(name: string, type: Lazy<Type>): this;
    buildRestParameter(name: string, kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildRestParameter(name: string, kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildRestParameter(name: string, kind: TypeBuilderKind.Tuple): TupleTypeBuilder<this>;
    buildRestParameter(name: string, kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;
    buildRestParameter(name: string, kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildRestParameter(name: string, kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildRestParameter(name: string, kind: TypeBuilderKind.Signature): SignatureBuilder<this>;

    setReturnType(type: Lazy<Type>): this;
    buildReturnType(kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildReturnType(kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildReturnType(kind: TypeBuilderKind.Tuple): TupleTypeBuilder<this>;
    buildReturnType(kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;
    buildReturnType(kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildReturnType(kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildReturnType(kind: TypeBuilderKind.Signature): SignatureBuilder<this>;

    setThisType(type: Lazy<Type>): this;
    buildThisType(kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildThisType(kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildThisType(kind: TypeBuilderKind.Tuple): TupleTypeBuilder<this>;
    buildThisType(kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;
    buildThisType(kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildThisType(kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildThisType(kind: TypeBuilderKind.Signature): SignatureBuilder<this>;

    setPredicateType(argument: string, constraint: Lazy<Type>): this;
    buildPredicateType(argument: string, kind: TypeBuilderKind.Class): ClassTypeBuilder<this>;
    buildPredicateType(argument: string, kind: TypeBuilderKind.Interface): InterfaceTypeBuilder<this>;
    buildPredicateType(argument: string, kind: TypeBuilderKind.Tuple): TupleTypeBuilder<this>;
    buildPredicateType(argument: string, kind: TypeBuilderKind.Union): UnionTypeBuilder<this>;
    buildPredicateType(argument: string, kind: TypeBuilderKind.Intersection): IntersectionTypeBuilder<this>;
    buildPredicateType(argument: string, kind: TypeBuilderKind.Anonymous): AnonymousTypeBuilder<this>;
    buildPredicateType(argument: string, kind: TypeBuilderKind.Signature): SignatureBuilder<this>;
}

which, in the end, looks like this when used:

const c1 = builder.startClassType()
    .addMember("x", BuilderMemberModifierFlags.Readonly, checker.getNumberType())
    .addMember("y", BuilderMemberModifierFlags.Readonly, checker.getNumberType())
    .buildConstructSignature()
        .addParameter("x", checker.getNumberType())
        .addParameter("y", checker.getNumberType())
        .setReturnType(getc1)
        .finish()
    .buildImplementsType(TypeBuilderKind.Interface)
        .addMember("x", BuilderMemberModifierFlags.Readonly, checker.getAnyType())
        .addMember("y", BuilderMemberModifierFlags.Readonly, checker.getAnyType())
        .setName("PointLike")
        .finish()
    .buildStatic("from", BuilderMemberModifierFlags.Public, TypeBuilderKind.Signature)
        .buildParameter("point", TypeBuilderKind.Anonymous)
            .addMember("x", checker.getNumberType())
            .addMember("y", checker.getNumberType())
            .finish()
        .setReturnType(() => c1)
        .finish()
    .finish();

if (checker.isAssignableTo(c1, someOtherType)) {
  // ...
}

The goal is to have a fluent API capable of creating an immutable version of any type or structure expressible within the type system. From my prototyping experience, there are only a handful of locations where a link or cache needed to be added to ensure the checker never needs to try to access an AST backing the types - so these "synthetic" or "declarationless" types actually tend to work fairly well within the checker once those are in-place. A few more links or hooks likely need to be added on top of those to ensure that the values are only retrieved lazily (rather than applied eagerly on API type creation). The laziness is actually super important for creating circularly referential types with an immutable API (otherwise a type can't really get a handle to it's finished self before it is done).

Known shortcoming: There's no method (in the type definition I have posted here) for making a member mapped to a well-known symbol, such as Symbol.iterator. I think this would just surface as parameters for object/class/interface members names taking string | WellKnownSymbol and having a method for looking up well-known symbols, though.

cc: @ahejlsberg @mhegazy @DanielRosenwasser @rbuckton

I'd love to hear everyone's thoughts on this - the general fluent creation API I've been working off and on for the last few weeks, and I think it has real promise for letting consumers make valid types safely (and the intellisense support is top notch).

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza revisando el prototipo en la rama type-builder y la propuesta relacionada de la API de relaciones en #9879. El issue presenta una superficie de TypeBuilder amplia y aún no definida, con varios diseños explícitamente inciertos, por lo que el alcance y los criterios de aceptación deben resolverse antes de la implementación. Para darlo por terminado sería necesario contar con una API acordada y la validación correspondiente del compilador de TypeScript.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
typescript
Área
compilers, devtools
Tipo de issue
Nueva funcionalidad
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Estancado
Claridad
Necesita aclaración
Aptitud para principiantes
25/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.