microsoft / microsoft/TypeScript

FSEvents watcher drops events when requested casing differs from disk casing

Abierto
#64,089 0 comentarios 0 reacciones 1 asignado Ver en GitHub

@andrewbranch ya está trabajando en esto.

Desde el 2/9/2026.

Needs Investigation
Lenguaje dominante
Go
Estrellas
111k
Forks
14.3k
Merge medio
2 d 4 h
PR fusionados (30 d)
132

Descripción

After https://github.com/microsoft/typescript-go/pull/4867, realpath on macOS now preserves the caller casing when the input isn't a symlink. That exposes a watch bug. WatchManager's DirWatchSet contains lowercased paths (even though they're typed as string, not tspath.Path). Those lowercased paths are given to fswatch, which works, but FSEvents then reports back events using actual disk casing. fsevents uses case-insensitive comparison to determine whether to call its callback, so the events get dropped.

I handed this to Copilot and it immediately jumped to bringing back the pre-https://github.com/microsoft/typescript-go/pull/4867 realpath behavior for directories specifically, since directories can't be hardlinks. I thought that was a really weird place to start, but technically it seems to fix the bug.

I think the more likely correct fix is either:

  • WatchManager should hold both the original file casing for passing to fswatch and lowercased casing for deduplication/comparison
  • fswatch should be doing case-insensitive matching on case-insensitive file systems

The latter seems like the most robust (I'm not sure if we can guarantee that the original file casing we see in tsc actually matches the disk in all cases; it seems possible that the casing of "include": ["SRC"] from a tsconfig will get preserved and we'll never be aware of the disk casing). But it also seems the most expensive and invasive, which is a bummer.

cc @jakebailey @johnfav03

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.