microsoft / microsoft/TypeScript

internal/ls: getContextNodeForNodeEntry returns nil for module-specifier literals (stock returns the enclosing import statement)

Aperta
#63,872 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

@gabritto ci sta già lavorando.

Dal 4/8/2026.

Needs Investigation
Lingua principale
Go
Stelle
111k
Fork
14.4k
Merge medio
1g 19h
PR unite (30g)
117

Descrizione

Stock's getContextNodeForNodeEntry (src/services/findAllReferences.ts:338) returns the enclosing import statement for a module-specifier string literal; tsgo returns nil. One visible effect: Go To Implementation on an import path returns a LocationLink whose target range is just the string literal instead of the whole import statement.

Minimal repro

Run go test ./internal/ls/ -run TestModuleSpecifierContextNode:

package ls

import (
	"testing"

	"github.com/microsoft/typescript-go/internal/ast"
	"github.com/microsoft/typescript-go/internal/core"
	"github.com/microsoft/typescript-go/internal/parser"
)

func TestModuleSpecifierContextNode(t *testing.T) {
	t.Parallel()
	text := "import { x } from \"./b\";\nx;\n"
	sourceFile := parser.ParseSourceFile(ast.SourceFileParseOptions{
		FileName: "/a.ts",
		Path:     "/a.ts",
	}, text, core.ScriptKindTS)

	var literal *ast.Node
	for _, stmt := range sourceFile.Statements.Nodes {
		if ast.IsImportDeclaration(stmt) {
			literal = stmt.AsImportDeclaration().ModuleSpecifier
		}
	}
	if literal == nil || literal.Kind != ast.KindStringLiteral {
		t.Fatalf("module specifier literal not found: %v", literal)
	}
	if ctx := getContextNodeForNodeEntry(literal); ctx == nil {
		t.Fatal("getContextNodeForNodeEntry(module specifier) = nil; want the enclosing import statement")
	}
}

Fails with getContextNodeForNodeEntry(module specifier) = nil on a pristine checkout (v7.0.2, 2bd066d8).

The string-literal special case diverges from stock's version (findAllReferences.ts:371): the case keys on node.Parent.Kind instead of the node itself, the FindAncestor predicate closes over the outer node instead of testing its parameter, and the outer gate's IsDeclaration(ImportDeclaration) is true in tsgo but false in stock. Same result for the other forms TryGetImportFromModuleSpecifier handles (export … from, import()/require(), …).

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.