microsoft / microsoft/TypeScript

tsc is not resposive to `ctrl-c`

Open
#63,856 2 comments 9 reactions 1 assignee Claimed by @jakebailey View on GitHub
Needs Investigation
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

When you run tsc and attempt to interrupt a build it does not respond instead it just complets the build

This is because typescript-go installs [signal handlers](https://github.com/microsoft/typescript-go/blob/8a749379d556f1bb4044218a1f94bc90fbfb6a03/cmd/tsgo/main.go#L28) to propagate sigterm and sigint to the `context.Context` object

However this is not always threaded all the way through the build

I prepared https://github.com/microsoft/typescript-go/pull/4592 to fix this, but the fix is non-trivial

Alternatively should we just _not_ install signal handlers and let normal behavior proceed?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.