microsoft / microsoft/TypeScript

Investigate decorator initialization order re: renames of classes

未关闭
#63,758 0 条评论 1 个 reaction 已指派 2 人 在 GitHub 查看

@RyanCavanaugh 已经在做这个了。

开始于 2026年8月20日。

  • #63929 来自 @copilot-swe-agent —— 未关闭
Needs Investigation
主要语言
Go
星标
111k
派生
14.3k
平均合并
2 天 4 小时
30 天内合并 PR
132

描述

> @copilot address the next CR comment and think hard about other edge cases

Investigated the CR comment on computed class-element names (`@dec class C { [C]() {} }`) and verified against real `tsc` (7.0.2, legacy decorators, ES2020/ES2022) using several variants: getter/setter computed names, a computed name with its own member decorator, a static property computed name, and a computed name inside a nested class within a method body. In every case, real `tsc` *does* substitute the class alias in computed class-member names (e.g. emits `[C_1.name]() {}`, not `[C.name]() {}`), including before the alias is actually assigned (this is a real, pre-existing bug/quirk in Strada's own emit, not something this PR should "fix"). I built `tsgo` and confirmed its output already matches `tsc`'s byte-for-byte for all these cases at the current `afb6df68` state.

So the CR suggestion to exclude computed class-element names from alias detection/substitution is incorrect — implementing it would make `tsgo` diverge from `tsc`. I made no code changes for this comment; current behavior is already correct.

_Originally posted by @Copilot in https://github.com/microsoft/typescript-go/issues/4650#issuecomment-5321088559_

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。