microsoft / microsoft/TypeScript
Allow classes to implement unions of object types
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Go
- Sterne
- 111k
- Forks
- 14.3k
- Ø Merge
- 2 T. 4 Std.
- Gemergte PRs (30 T.)
- 132
Beschreibung
🔍 Search Terms
class extends union type
✅ Viability Checklist
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
⭐ Suggestion
Allow classes to extend unions of object types when the types in the union have the same set of properties.
The goal is to allow type-narrowing on class instances by checking a discriminant field.
📃 Motivating Example
I often have classes that represent data that can be in one of several states, and whose fields depend on that state.
An example is an object that is imported into a database with a long task. The app will write a record to the database to indication that it's currently being imported, and locking it from other writers.
We might model that with two interfaces: ImportingFoo, and ImportedFoo, discriminated by a status field:
type FooStates = ImportingFoo | ImportedFoo;
interface ImportingFoo {
status: 'importing';
value: undefined;
}
interface ImportedFoo {
status: 'imported';
value: string;
}
We want our class to implement this type to indicate what type value can be depending on the type of status:
class Foo implements FooStates {
status: 'importing' | 'imported' = 'importing';
value: undefined | string;
}
This currently gives a "A class can only implement an object type or intersection of object types with statically known members.(2422)" error.
If we could do that, we could use narrowing for the instance:
const getValue = (foo: Foo): string => {
if (foo.status === 'imported') {
return foo.value; // OK, because foo narrowed to a ImportedFoo
}
throw new Error('Invalid state');
}
💻 Use Cases
- What do you want to use this for?
- Classes that act as discriminated unions
- What shortcomings exist with current approaches?
- The class can't explicitly implement the union, narrowing doesn't automatically work
- What workarounds are you using in the meantime?
- Cast the instance to an intersection of the class and interface:
foo as Foo & ImportedFoo, but this is error prone as the cast will succeed in cases where it shouldn't.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, die Validierung von implements für Klassen nachzuverfolgen, die die Diagnose 2422 erzeugt, und untersuche anschließend, wie die Narrowing-Logik für Discriminated Unions bei Klasseninstanzen funktioniert. Vergleiche die vorgeschlagenen Beispiele FooStates und Foo, und identifiziere die Compiler-Tests, die die Implementierung von Klassen und das Narrowing abdecken. Fertig ist die Aufgabe, wenn gültige Union-Implementierungen akzeptiert werden und die gezeigte foo.status-Prüfung foo.value korrekt eingrenzt, ohne die JavaScript-Ausgabe zu ändern.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- typescript
- Bereich
- compilers
- Issue-Typ
- Feature
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 25/100