microsoft / microsoft/TypeScript

Support `@deprecated` marker on namespace aliases

Abierto
#62,340 0 comentarios 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Domain: JSDoc Help Wanted Possible Improvement
Lenguaje dominante
Go
Estrellas
111k
Forks
14.3k
Merge medio
2 d 4 h
PR fusionados (30 d)
132

Descripción

🔍 Search Terms

"@deprecated", "deprecated", "namespace", "namespace alias"

✅ Viability Checklist
⭐ Suggestion

Note: Marking this as a feature request, very well might be a bug. It's one of those that are probably up for interpretation?


I'd like the ability to annotate namespace aliases with @deprecated. At the moment you'd need to mark the referenced type as deprecated, which often isn't viable.

Here's a little example:

// @filename: example.d.ts
export type Bar = string | number;

/** @deprecated */
export type Baz = string | number;


// @filename: foo.ts
import * as example from './example';

declare namespace JSX {
	/** @deprecated */
	export type Foo = string | number;

	/** @deprecated */
	export import Bar = example.Bar;

	export import Baz = example.Baz;
}

let x: JSX.Foo;  // Marked as deprecated
let y: JSX.Bar;  // Not marked as deprecated (but should be)
let z: JSX.Baz;  // Marked as deprecated

TypeScript Playground Link

📃 Motivating Example

Allows developers to mark namespace aliases as deprecated, giving downstream users more warning when those aliases will go away.

💻 Use Cases
  1. What do you want to use this for?

preact has long since loaded up the JSX namespace with unrelated types... shouldn't have, but did. We're looking to get rid of this in our next major and to help folks migrate we wanted to extract the types to the preact namespace and re-export them as aliases through the JSX namespace. This will avoid any breaking changes in the current version and allow folks to keep compatibility with v10 and the upcoming v11.

Unfortunately, however, we can't mark this usage as deprecated which is a shame.

  1. What shortcomings exist with current approaches?

Just doesn't work. End users get no warning that the namespace alias is deprecated.

  1. What workarounds are you using in the meantime?

Just duplicated all the types. Instead of extracted types that are consumed both as direct exports and namespace aliases, we've had to make copies. Those in the namespace get the deprecation comment, those outside do not.

It's pretty fragile obviously, any change to one now has to be reflected to the same interface in another file.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza con el ejemplo de TypeScript Playground del issue y sigue cómo se informa la obsolescencia de los miembros de namespace y los alias de tipos. Añade cobertura de regresión para export import Bar = example.Bar de modo que JSX.Bar se marque como obsoleto, mientras que el comportamiento existente de JSX.Baz permanezca sin cambios. Se considera terminado cuando los alias de namespace producen la advertencia de obsolescencia esperada sin cambiar la salida de JavaScript.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
typescript
Área
compilers
Tipo de issue
Nueva funcionalidad
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.