microsoft / microsoft/TypeScript
Allow explicit fallthrough when noFallthroughCasesInSwitch is enabled
Nessuno ha ancora preso questa issue.
- Lingua principale
- Go
- Stelle
- 111k
- Fork
- 14.3k
- Merge medio
- 1g 19h
- PR unite (30g)
- 117
Descrizione
🔍 Search Terms
fallthrough noFallthroughCasesInSwitch
✅ Viability Checklist
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
⭐ Suggestion
switch (...) {
case 'A':
doSomething();
// fallthrough - this will allow falling to next statement
case 'B':
doSomethingElse();
}
Instead of usage of @ts-expect-error this is nicely readable and intention is clearly visible in generated code.
📃 Motivating Example
Until now for noFallthroughCasesInSwitch is missing good way to allow falling through if needed. The only possible way @ts-expect-error is disabling not only fallthrough check, but also other checks which is not desired.
💻 Use Cases
-
What do you want to use this for? Because eslint rule no-fallthrough does not handle TS exhaustive match, I would like to you
noFallthroughCasesInSwitchconfig rule -
What shortcomings exist with current approaches?
- eslint can not be used, its
no-fallthroughrule can not detect exhaustive match, so the following code is incorrectly reported by eslint:
function transform(action: 'KEEP' | 'INVERSE', b: boolean): boolean { switch (action) { case 'KEEP': switch (b) { case true: return true; case false: return false; } case 'INVERSE': switch (b) { case true: return false; case false: return true; } } }- satisfying eslint is not possible e.g. by putting
break, because TS will start report Unreachable code detected and this can not be disabled by@ts-expect-error - disabling reported case by
@ts-expect-erroris also not viable, because it is disabling all type checks, so e.g. in casecase something:validation thatsomethinghas the correct type is also disabled (and issue #19139 is still opened)
- eslint can not be used, its
-
What workarounds are you using in the meantime? In my specific case, I had only one of these switches with exhaustive match, so I could put the statement as the last to not disable any check.
Implementation of #19139 would give me decent workaround and it is definitely more useful that this specific feature, but I believe both of them should be implemented.
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
L’issue non indica file né test; inizia individuando la diagnostica noFallthroughCasesInSwitch e i controlli del flusso di controllo di switch nel compilatore TypeScript. Confronta il marker di fallthrough proposto con i casi esistenti di @ts-expect-error ed exhaustive-match, quindi aggiungi una copertura mirata che dimostri che il fallthrough intenzionale continua a essere sottoposto al controllo dei tipi.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- typescript
- Ambito
- compilers
- Tipo di issue
- Funzionalità
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 35/100