microsoft / microsoft/TypeScript
Revert ts5.9 changes for Uint8Array
Personne n'a encore pris cette issue.
- Langage dominant
- Go
- Étoiles
- 111k
- Forks
- 14.3k
- Merge moyen
- 2 j 4 h
- PR mergées (30 j)
- 132
Description
⚙ Compilation target
es2022
⚙ Library
es2022, dom
Missing / Incorrect Definition
- User sees weird error. "Uint16Array is not assignable to Uint16Array". First thoughts: WTF? What does this even mean? "But I don't use SharedArrayBuffer in my project!!"
TS2345: Argument of type 'Uint16Array' is not assignable to parameter of type 'Uint16Array<ArrayBuffer>'.
Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'.
Types of property '[Symbol.toStringTag]' are incompatible.
Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"'.
- User heads to blog post and sees "explicitly writing out
Uint8Array<ArrayBuffer>rather than a plainUint8Array" - User applies the changes.
- The changes make library unusable in TS <=5.6.
- User reverts to older TS to ensure his library doesn't require "latest ts".
- There is zero other documentation about resolving the problem, so it's unclear how to solve it. It's also not obvious that
() => new Uint8Array,() => Uint8Array.from([])and() => Uint8Array.of()now all return subtyped uint8array, which fails in TS <=5.6
Previous issue text
ts5.7 change which made uint8arrays generic was okay.
ts5.9 introduced absolutely horrific change which breaks Uint8Array-heavy projects.
It seems like some changes made types too strict. It's unclear at which phase - perhaps during inference (i'm using infer). I'm now constantly getting those errors and it's really unhelpful - it's unclear what to do. Blog post recommendations (https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-9.html#libdts-changes) make arrays subtype-specific. It seems like this is a wrong way to fix things. Users should not be forced to always consume ArrayBuffer-based type arrays. It's perfectly fine to use either ArrayBuffer or SharedArrayBuffer based arrays, the changes are minor. The defaults should be able to consume both types!
// type Poly = Uint16Array
TS2345: Argument of type 'Poly' is not assignable to parameter of type 'Uint16Array<ArrayBuffer>'.
Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'.
Types of property '[Symbol.toStringTag]' are incompatible.
Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"'.
Sample Code
I've spent a lot of time but was not able to produce a standalone example which reproduces the issue. There are a bunch of types at play and it's unclear which exact type causes the issue.
The code which produces errors is in commit cb76058 of https://github.com/paulmillr/noble-post-quantum
git clone https://github.com/paulmillr/noble-post-quantum
cd noble-post-quantum
git checkout cb76058
npm install
npm run build
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par les modifications de TypeScript 5.9 lib.d.ts décrites dans les notes de version liées, puis reproduisez l’échec signalé à l’aide du commit cb76058 de noble-post-quantum et de sa commande npm run build. Comparez le comportement de Uint8Array entre les versions de TypeScript, en considérant le travail terminé lorsque les définitions concernées restent utilisables avec les versions de TypeScript prises en charge, plus récentes comme plus anciennes.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- typescript
- Domaine
- compilers
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100