microsoft / microsoft/TypeScript
Bloomberg feedback for 5.9
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Go
- Estrellas
- 111k
- Forks
- 14.3k
- Merge medio
- 2 d 4 h
- PR fusionados (30 d)
- 132
Descripción
### Comment
We evaluated the 5.9 RC releases and 5.9 is a low impact release for us.
| # | Change | Affects | Release notes | Packages affected | PR / Issue |
| - | -------------------------------------------------------------------------- | ---------------- | ------------- | ----------------- | ---------- |
| 1 | Class expressions with private fields produce invalid `.d.ts` output | Declaration Emit | No | <1% | [#62153](https://github.com/microsoft/TypeScript/issues/62153) |
| 2 | `Promise.all` over constant tuples no longer infers tuple | Type Checking | No | <1% | [#62071](https://github.com/microsoft/TypeScript/issues/62071) |
| 3 | JavaScript emit removes parentheses around `??` in conditional expressions | Emit | No | <1% | – |
| 4 | Better detection of always-true errors in `??` expressions | Type Checking | No | <1% | – |
## Class expressions with private fields produce invalid `.d.ts` output
With TypeScript 5.9, the following code:
```ts
export const ClassExpression = class {
#context = 0
};
```
Produces invalid declaration output:
```ts
export declare const ClassExpression: {
new (): {
#context: number;
};
};
```
5.8 output was also incorrect but at least syntactically valid:
```ts
export declare const ClassExpression: {
new (): {
"__#1@#context": number;
};
};
```
❗This seems like a major regression, since emitted declarations are now invalid.
Tracked in [#62153](https://github.com/microsoft/TypeScript/issues/62153)
## `Promise.all` over array literal no longer infers a tuple
This issue is easier to reproduce than the linked ticket may suggest. It affects any use of `Promise.all` in the return position of a `.then()` that chains from a promise resolving to an array:
```ts
const p = Promise.resolve([]).then(() => {
return Promise.all([0, ""]);
});
const test: Promise<[number, string]> = p; // error
```
This now fails to infer a tuple and infers `Promise<(string | number)[]>` instead.
While we can work around this issue by assigning the result of `Promise.all` to an intermediate variable, this does seem like an unfortunate regression.
Tracked in [#62071](https://github.com/microsoft/TypeScript/issues/62071)
## JavaScript emit removes parentheses around `??` in conditional expressions
In some cases, parentheses are removed from nullish coalescing expressions in emitted JavaScript. This change seems benign.
```ts
(test ?? true) ? A : B
```
Becomes:
```ts
test ?? true ? A : B
```
## Better detection of always-true errors in `??` expressions
We observed two new diagnostics related to always-true `??` expressions.
The improved detection highlighted logic errors that were previously missed.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con los fragmentos de reproducción del issue y los tickets enlazados #62153 y #62071, que hacen seguimiento de dos de las regresiones reportadas. Compara el comportamiento de declaración o de type-checking entre 5.8 y 5.9 y, después, limita cualquier trabajo a una regresión confirmada; el informe en sí no identifica archivos, pruebas ni una única Definition of done.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript, typescript
- Área
- compilers
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 15/100