microsoft / microsoft/TypeScript
Preserve computed property in `--isolatedDeclarations` emit
Personne n'a encore pris cette issue.
- Langage dominant
- Go
- Étoiles
- 111k
- Forks
- 14.3k
- Merge moyen
- 2 j 4 h
- PR mergées (30 j)
- 132
Description
### 🔍 Search Terms
isolated declarations, computed properties
### ✅ Viability Checklist
- [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
- [x] This wouldn't change the runtime behavior of existing JavaScript code
- [x] This could be implemented without emitting different JS based on the types of the expressions
- [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- [x] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- [x] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
### ⭐ Suggestion
Now that #60052 allows for (some) computed properties in in `.d.ts` files I think the next step is for `--isolatedDeclaration` to be updated to not error and to emit the computed properties. Opening this issue if helpful to track this work.
I believe the previous plan (#58800) to introduce a new syntactic marker is no longer required.
Related issues: #58533 #60818 #61068
### 📃 Motivating Example
```ts
export const prop: unique symbol = Symbol();
export class MyClass {
[prop] = () => Math.random();
}
```
### `@isolatedDeclarations: false`
[playground](https://www.typescriptlang.org/play/?isolatedDeclarations=false&ts=5.8.3#code/PTAEAEEsGcHsBsCGAXApgEwCKoMZIE4qSwB20AXKAGaLzSoBQqAHgA6z7Kg6nRev5YrSgFcSkAI4jUoaAE8AtgCMEoALygAyopXwAFAEoA3AyZsOXPImjRQAWTkBhJDdABvBqC+gA2gKEAuuqghuoAfPYoABYAdIQk6LAKhiYAvgxAA)
```ts
export declare const prop: unique symbol;
export declare class MyClass {
[prop]: () => number;
}
```
### `@isolatedDeclarations: true` (current 🙁)
[playground](https://www.typescriptlang.org/play/?isolatedDeclarations=true&ts=5.8.3#code/PTAEAEEsGcHsBsCGAXApgEwCKoMZIE4qSwB20AXKMvgK6oBQqAHgA6z7Kg6nScv6wWlGiUgBHOqGgBPALYAjBKAC8oAMpzF8ABQBKANz1GrdpzyJo0UAFlpAYSSXQAb3qh3oANr9BAXRWgeioAfDYoABYAdIQk6LCyeoYAvvRAA)
```sh
ts(9038) Computed property names on class or object literals cannot be inferred with --isolatedDeclarations.
```
```ts
export declare const prop: unique symbol;
export declare class MyClass {
}
```
### `@isolatedDeclarations: true` (future 🚀 )
No error and same emit as `@isolatedDeclarations: false`
```ts
export declare const prop: unique symbol;
export declare class MyClass {
[prop]: () => number;
}
```
### 💻 Use Cases
The primary use case is enabling isolated declarations at scale on large codebases that make heavy use of computed properties.
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par reproduire l’exemple motivant avec --isolatedDeclarations et examinez les issues associées #60052, #58800, #58533, #60818 et #61068. Suivez la gestion existante des déclarations isolées pour les propriétés calculées ; le travail est terminé lorsqu’aucun diagnostic n’est émis et que le declaration emit préserve [prop] avec le type de retour number de la fonction.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- typescript
- Domaine
- compilers
- Type d'issue
- Fonctionnalité
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 45/100