microsoft / microsoft/TypeScript

Static Index Signature with Generics

Aperta
#60,587 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Awaiting More Feedback Suggestion
Lingua principale
Go
Stelle
111k
Fork
14.3k
Merge medio
2g 4h
PR unite (30g)
132

Descrizione

🔍 Search Terms
✅ Viability Checklist
⭐ Suggestion

Currently, static index signatures can be declared for a type, under the condition, that the mapping cannot be a literal type or generic type. My proposal is to allow TypeScripts' powerful typing system on static indexing by removing this restriction. As you see below, there is one utility type that already allows the elimination of a string subset, that being Uppercase.

class Abc{
    static readonly [k: number]: number;
}

class Def{
    static readonly [k: number | Uppercase<string>]: number; // This is allowed
    static hello() {} // Since `'hello' extends Uppercase<string> ? true : false` yields false, this is allowed.
}

By allowing generic indexing, the "value" type can be further specified by the "key" type. Currently, static index signatures with string mapping have the problem of overriding (lowercase) method types, causing the type checker to warn a conflict. By allowing TS' conventional T in Types notation, the subset of index keys can be decreased and shown in InteliSense, and also providing the value type based on key set.

📃 Motivating Example

TypeScript's powerful type system can now be used in static and non-static index signatures, allowing you to type generic indexation.

💻 Use Cases

This can be used to provide great simplifications for API writers, by exposing a niche interface and type hinting on a class. Currently this is possible by obfuscating a class with another type, which is not that great, or using a typed proxy, which is the best approach currently. However all of these mean that the projects' classes have to be split and harder to maintain. There is no way, other than with Uppercase to limit static string index signatures.

By using generic index signatures, as well as being able to use them in static context, a lot of type workload can be exercised within a class range.

const Format = {
    'PlayerJoin': [number, string],
    'PlayerChat': [number, string],
    'PlayerLeave': [number],
}

export class MessageType<F extends keyof typeof Format> {
    // This will allow to index `MessageTypes` as a collection of data entries.
    [Index in number]: (typeof Format)[F][Index];

    // Type System: (typeof Format)[F][0] ~> [number, ...][0] ~> number
    public get playerId() { return this[0]; }

    // This is already possible, nothing of too much interest
    constructor(messageType: F) { return Proxy(...) }
}

The fun part comes when you have a collection like Block or Item, where you not only want to have some internal state, but also allow to list all "content" statically on the class.

const Blocks = [
    { id: 0, name: "air" },
    { id: 1, name: "earth" },
    { id: 2, name: "water" },
];

export class Block<Id extends (typeof Blocks)[number]['id']> {
    // Currently, InteliSense will tell you, that using the generic argument from the class is not supported. This should be kept as a feature, but adding new generic types should not be hindered
    static readonly [SId in (typeof Blocks)[number]['id']]: Block<SId>;
    ...
}

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

La issue non indica file di implementazione, test o punti di ingresso; inizia esaminando le firme di indice generiche statiche proposte e le issue collegate. Definisci il comportamento del sistema dei tipi e le regole di compatibilità, quindi aggiungi test del compilatore che coprano i casi accettati e rifiutati, così da verificare l'indicizzazione statica generica richiesta.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
typescript
Ambito
compilers
Tipo di issue
Funzionalità
Difficoltà
5/5
Tempo stimato
Più di una settimana
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
30/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.