microsoft / microsoft/TypeScript

Ability to pick setter types (instead of getter types) in a mapped type

Offen
#60,162 3 Kommentare 5 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Awaiting More Feedback Suggestion
Vorherrschende Sprache
Go
Sterne
111k
Forks
14.4k
Ø Merge
1 T. 19 Std.
Gemergte PRs (30 T.)
117

Beschreibung

🔍 Search Terms

typescript extract setter types mapped type

✅ Viability Checklist
⭐ Suggestion

(original thread on Discord)

This might be a request for a new utility type, or a new language feature, because there seems to be no way to do it with current language features currently:

Given this type:

class Foo {
  get foo(): number {...}
  set foo(v: 'foo' | 'bar' | number) {...}
}

We want to derive a type like this:

type Derived = PickWithSetterTypes<Foo>
// result:
// {foo: 'foo' | 'bar' | number}

There seems to be no way to implement PickWithSetterTypes in userland.

📃 Motivating Example

When writing class-based JSX components (for example, custom elements are written as classes), the JSX property types are setters, not getters.

In this JSX expression:

return <some-element foo={123} />

The foo prop is a setter, and it is setting the property on the custom element, it is not reading the property from the element.

So, when we define a class component, for example:

class SomeElement extends HTMLElement {
  get foo(): number {...}
  set foo(v: 'foo' | 'bar' | number) {...}

  someMethod() {... this method should not be included in JSX types ...}
}

customElements.define('some-element', SomeElement)

We need to pluck the properties that we want available in the JSX. For example, something along the lines of this:

declare module 'some-lib' {
  namespace JSX {
    interface IntrinsicElements {
      'some-element': Pick<SomeElement, 'foo'>
    }
  }
}

Now, the problem is, when we try to set a valid value for the property in JSX, it will not work:

return <some-element
  foo={'foo'} // Type Error: 'foo' is not assignable to number
/>

There should not be a type error, because the setter actually does accept the value 'foo'.

💻 Use Cases
  1. What do you want to use this for?
    • Any situations where the setter types need to be extracted, for example JSX props
  2. What shortcomings exist with current approaches?
    • it is impossible right now
  3. What workarounds are you using in the meantime?
    • Workarounds could include providing separate named properties that can be extracted with template string types, but it is very cumbersome
      class SomeElement extends HTMLElement {
        set foo(v: this['_set_foo']) {...}
        get foo(): number {...}
        
        /** do not use this property, it is for types only */
        _set_foo!: 'foo' | 'bar' | number
      }
      
      With this method, now a utility type can be written that can use template string types to extract the setter type from the non-setter dummy property type, something like this:
      type SomeElementJSXProps = JSXProps<SomeElement, 'fooBar' | 'foo'> // see linked playground below
      
      declare module 'react' {
          namespace JSX { interface IntrinsicElements { 'my-el': SomeElementJSXProps } }
      }
      
      TypeScript playground example

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne mit dem verlinkten TypeScript Playground-Beispiel und den mapped-type-, getter/setter- und JSX-Szenarien des Issues; der Payload nennt keine Repository-Dateien, Tests oder Einstiegspunkte. Lege das Design und die Akzeptanzfälle rund um das Extrahieren von Setter-Typen fest und bewahre dabei das bestehende Getter- und JSX-Verhalten; identifiziere anschließend die relevanten Compiler-Tests und Implementierungsbereiche.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
typescript
Bereich
compilers, developer-experience
Issue-Typ
Feature
Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
28/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.