microsoft / microsoft/TypeScript
Don't allow falsely discarded parameters when determining overloaded signature compatibility
还没有人认领这个 Issue。
- 主要语言
- Go
- 星标
- 111k
- 派生
- 14.4k
- 平均合并
- 1 天 19 小时
- 30 天内合并 PR
- 117
描述
Motivation
Libraries such as Knockout use overloaded functions, for example:
var x = new MyKnockoutModel();
console.log(x.customerName()); // string
x.customerName('bob'); // OK
x.customerName(42); // Error, 42 is not a string
We can model these in TypeScript:
interface KnockoutElement<T> {
// Getter
(): T;
// Setter
(value: T): void;
}
However, these overloads turn out to not be safe when used in callbacks. For example:
function readFile(finished: (contents: string) => void) { /*... */ }
var ko: KnockoutElement<number>;
readFile(ko); // No error, but passes a string to a number-expecting setter!
This is because we look at all the candidate source signatures, reject the (x :number) => void signature for having an incompatible type, and accept the () => T signature because it has fewer parameters (an acceptable variance).
This behavior does not map to any actual runtime behavior. The invoker's side might check the .length property of the function to determine what kind of arguments to pass, and the invokee's side might check arguments.length to determine which overload was intended, but the invoker cannot tell what the expected parameter type of the function is, and the invokee reasonably expects to be called with the correct type given a certain arity.
Proposal
As an example, if a callback declaration says it’s going to invoke f with two parameters, we should not consider overloads of f which take zero arguments if an overload with one or two arguments exists.
In 3.8.3 / 3.8.4:
M is a non-specialized call or construct signature and S’ contains a call or construct signature N where […]
Change to
M is a non-specialized call or construct signature and S’ contains a call or construct signature N where no other call or construct signature in S’ has more parameters than N but not more than M, and […]
Analysis
A sample implementation of this rule breaks no existing tests. Check stopParameterNeglect branch for code/tests.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从提案开始,检查 stopParameterNeglect 分支,包括其中的代码和测试。先运行现有测试,然后将签名兼容性行为与提议的参数数量规则进行比较。完成的标准是:当存在一个在 callback 的元数范围内接受更多参数的兼容 overload 时,不选择接受更少参数的 overload,同时不破坏现有测试。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- typescript
- 领域
- compilers
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 48/100