microsoft / microsoft/TypeScript

Type PermissionName for Permission API doesn't contain microphone and camera devices

Abierto
#59,805 2 comentarios 1 reacción 1 asignado Ver en GitHub

@sandersn ya está trabajando en esto.

Desde el 30/8/2024.

Needs Investigation
Lenguaje dominante
Go
Estrellas
111k
Forks
14.4k
Merge medio
1 d 19 h
PR fusionados (30 d)
117

Descripción

🔍 Search Terms

microphone, camera, device, permission, state, API, navigator

✅ Viability Checklist
⭐ Suggestion

In both files, webworker.generated.d.ts and dom.generated.d.ts in line 9361 and 27992.

The modification would be add two terms in the type PermissionName. 'camera' and 'microphone' to check access in both devices

📃 Motivating Example
  const checkForPermission = (type: PermissionName) => {
    navigator.permissions
      .query({
        name: type,
      })
      .then(permissionStatus => {
        // Will be 'granted', 'denied' or 'prompt':
        console.log(permissionStatus);
        // permissionStatus.state = 'granted'
        // Listen for changes to the permission state
        permissionStatus.onchange = () => {
          console.log(permissionStatus.state);
        };
      });
  };

  checkForPermission('microphone');
  checkForPermission('camera');

Expected behavior:
'microphone' and 'camera' should be valid types for PermissionName type.

Actual behavior:
'microphone' and 'camera' are not valid types for PermissionName type.
Typescript is showing error:
Argument of type '"microphone"' is not assignable to parameter of type 'PermissionName'.

💻 Use Cases
  1. What do you want to use this for?
    Check if camera or microphone are enabled/disabled

  2. What shortcomings exist with current approaches?
    To type the promise from navigator.permission in typescript, we have to add a inclusion on type PermissionName like: { PermissionName } & { name: 'camera' | 'microphone' }.

  3. What workarounds are you using in the meantime?
    I'm using it: { PermissionName } & { name: 'camera' | 'microphone' }

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.