microsoft / microsoft/TypeScript

Allow leading underscore for types to bypass noUnusedLocals warning

Aperta
#58,561 6 commenti 16 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Help Wanted Suggestion
Lingua principale
Go
Stelle
111k
Fork
14.3k
Merge medio
1g 19h
PR unite (30g)
117

Descrizione

🔍 Search Terms

"ts-ignore", "ts-expect-error", "noUnusedLocals", "noUnusedLocals underscore", "noUnusedLocals prefix"

✅ Viability Checklist
⭐ Suggestion

Add support for leading underscore in type definition name to disable tsc noUnusedLocals warning ts(6196), like it does for other things.

📃 Motivating Example

Allows for easier testing of types by providing a way to enabled noUnusedLocals for your project, and selectively opting out for local types used for testing. Prior to this, you had a couple of less than idea solutions:

  1. live with the warnings
  2. disable noUnusedLabels for test code
  3. use @ts-ignore

Depending on the method you're using for testing your types, you might not be able to use @ts-ignore. For example, if you were relying on usage of @ts-expect-error to assert invalid usages of your types in tests, @ts-ignore would also cause typescript not to flag the type error you're trying to assert with @ts-expect-error.

For example, a test like this:

type StringKeyOf<T extends Record<string, unknown>> = T extends T
  ? Extract<keyof T, string>
  : never;

type TestType = { s: unknown; 1: unknown; };

// NOTE: `expectFails` type will get flagged with unused warning, when `noUnusedLocals` is enabled,
//     and `@ts-ignore` is no help because it also suppresses the compile error we want to validate

// @ts-expect-error - validate type error will occur
type expectFails = Expect<Equals<StringKeyOf<TestType>, 's' | 1>>;

Previously, prefixing the local type with underscore would have no affect on the warning, but now you can update the code to include a leading underscore for the type name, and the warning will go away.

// @ts-expect-error
type _expectFails = Expect<Equals<StringKeyOf<TestType>, 's' | 1>>;
💻 Use Cases
  1. What do you want to use this for?
    • I'd like to use to in my type validation tests.
  2. What shortcomings exist with current approaches?
    • The current approaches do not provide a very good way to avoid ending up with a lot of warnings in tests, without disabling noUnusedLocals
  3. What workarounds are you using in the meantime?
    • I'm currently disabling noUnusedLocals in my project's base tsconfig.json and enabling in tsconfig.build.json. This choice was made so the errors would not be present for developers working on test related code, and since the build config does not include tests, it applies the rule against production code. It results in a less than ideal developer experience though, because developers will see errors in build that don't present when viewing the source code, because vscode is using tsconfig.json.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia riproducendo l’esempio motivante con tsc e noUnusedLocals, quindi traccia la diagnostica per il tipo locale non utilizzato. Il lavoro è completato quando un carattere di sottolineatura iniziale sopprime ts(6196) per quel tipo, mentre il comportamento esistente e il JavaScript emesso rimangono invariati.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
typescript
Ambito
compilers
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.