microsoft / microsoft/TypeScript

static fields should be installed on the decorated class

Abierto
#57,237 3 comentarios 0 reacciones 1 asignado Ver en GitHub

@rbuckton ya está trabajando en esto.

Desde el 30/1/2024.

Bug Domain: Decorators
Lenguaje dominante
Go
Estrellas
111k
Forks
14.4k
Merge medio
1 d 19 h
PR fusionados (30 d)
117

Descripción

🔎 Search Terms

decorator class static field

🕗 Version & Regression Information
  • This is a crash
  • This changed between versions ______ and _______
  • This changed in commit or PR _______
  • This is the behavior in every version I tried (after ES decorators are implemented), and I reviewed the FAQ for entries about decorators
  • I was unable to test this on prior versions because _______
⏯ Playground Link

https://www.typescriptlang.org/play?useDefineForClassFields=true&target=9&ts=5.4.0-dev.20240130#code/DYUwLgBA8gTglgczgOwIbAGIHssG4BQ+AxsKgM5kQBCqMEA3gL6EBmArskWHFshACYgiACmxYAlA3wRo8JGkw4IAXghiCMmODYw+NGAWb4AAoKLFSFNUvrSIZMKm5EIABw33HziKiJEQFFh0qB4OTnAuALbCkkz4RkS8ZFigAHTAWAjC+qkAFuRQAO7IAAowWK4gMGAAnsIARK714gA01LR5BcVlFVW1DajNbTn5ZEWl5ZXVdfWRzeIEicjJaRlZsIgo6GKdY92TfTNNrbKbCjuj4z1T-fWDJxvy2zi7VwfTDXPiC0A

💻 Code
let OriginalFoo;

class Bar {}

function dec(Foo) {
  OriginalFoo = Foo;
  return Bar;
}

@dec
class Foo {
  static p;
  static accessor a;
  static m() {}
}

console.log(Bar.hasOwnProperty("p"), Bar.hasOwnProperty("a"), Bar.hasOwnProperty("m"));
console.log(OriginalFoo.hasOwnProperty("p"), OriginalFoo.hasOwnProperty("a"), OriginalFoo.hasOwnProperty("m"));
🙁 Actual behavior

It prints

false,  false,  false 
true,  true,  true 
🙂 Expected behavior

It should print

true, true, false
false, false, true
Additional information about the issue

Per RS: ClassDefinitionEvaluation:
In step 27 the static methods are installed to the original class OriginalFoo.
In step 37 the receiver F is assigned by the decorated class Bar.
In step 40 the static fields and accessors are initialized on the decorated class Bar.
So OriginalFoo should contain all the static methods while Bar should contain all the static fields and accessors.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.