microsoft / microsoft/TypeScript

Provide Compiler API way to disable type checking for a source file

Abierto
#57,015 2 comentarios 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Awaiting More Feedback Suggestion
Lenguaje dominante
Go
Estrellas
111k
Forks
14.3k
Merge medio
1 d 19 h
PR fusionados (30 d)
117

Descripción

⭐ Suggestion

This request is for a public Compiler API means to disable type checking for individual SourceFile instances that are part of a ts.Program.

There are several ways to indirectly tap into this behavior, but none of them seem to be convenient to use from a Compiler API script.

  • A source file could have // @ts-nocheck explicitly written out.
  • Setting skipLibCheck / skipDefaultLibCheck will skip type checking for declaration source files.
  • JavaScript files under allowJs without checkJs I believe are another flavor of skipping type checking.

It would be nice if it was as simple as sourceFile.skipTypeChecking = true followed by requesting diagnostics. Or have the APIs accept a function (sourceFile: SourceFile) => boolean that is called to make the decision to type check or not.

📃 Motivating Example

I am trying to improve the compile performance of a very large TypeScript monorepo. This is on the scale of thousands of tsconfig.json files, and tens of thousands of source files.

Across the repository, source files have freely referenced each other. The tsconfig.json projects all extend from a common base and the purpose of them was mainly to just to light up IDE support and split out reasonably-sized chunks of source files to compile together.

As the codebase has grown over time, performance has plummeted under the default behavior of the compiler:

  • One tsconfig.json might "own" say 15 files, those within the subdirectory it is in.
  • The compiler parses those 15, then finds more dependencies, and more dependencies of those... and more dependencies of those.
  • Suddenly each ts.Program balloons into doing compilation work for thousands of transitive dependencies. That effort is unwanted, because those dependencies really should ideally just be checked when "their own" tsconfig.json is being compiled.

I know that Project References would be the best way to address this performance problem. We'd create strict project boundaries, and the "15 source files" in the example above would be type checked against .d.ts files rather than other full source files. It is a very large undertaking to take existing code that hasn't "followed the rules" and conform it though.

We already use the Compiler API for other reasons, and I've been experimenting with tweaks to ts.skipTypeChecking() to try to reduce the unwanted type checking work. It seems really promising to have skipTypeChecking short-circuit the type checking work for the transitive dependencies that pull into a ts.Program in my case.


I'd also note that a feature like this in the Compiler API could enable "power users" to implement something like #28260 on their own.


Finally, I'd note that I'm certainly open to other suggestions here, or any advice / caution about the skipTypeChecking trickery I'm delving into!

💻 Use Cases

What do you want to use this for?

  • A power user feature in the Compiler API to control what source files get type checked.

What shortcomings exist with current approaches?

  • Trying to tap into // @ts-nocheck dynamically feels extremely roundabout, and in particular has some bugs (#56956)
  • skipLibCheck is similar functionality, except I want to skip "a certain large swath of non-declaration files" instead.

What workarounds are you using in the meantime?

  • The most practical approach I have found to achieve an immediate widespread performance improvement is to patch the internal skipTypeChecking function with extra logic like if (sourceFile.skipTypeChecking) { return true; } and then set sourceFile.skipTypeChecking = true on the transitive dependency source files.
🔍 Search Terms

skipTypeChecking, ts-nocheck

✅ Viability Checklist

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Empieza leyendo src/compiler/utilities.ts en la función skipTypeChecking mencionada y las rutas de Compiler API que solicitan diagnósticos. Compara el flag propuesto por SourceFile con una API basada en callbacks y con el comportamiento existente de ts-nocheck, skipLibCheck y skipDefaultLibCheck. Se considera terminado cuando una API compatible permite omitir selectivamente la comprobación de tipos para instancias de SourceFile sin cambiar el JavaScript emitido.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
typescript
Área
compilers
Tipo de issue
Nueva funcionalidad
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.