microsoft / microsoft/TypeScript

Strict index signatures option

Aperta
#56,378 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Awaiting More Feedback Suggestion
Lingua principale
Go
Stelle
111k
Fork
14.3k
Merge medio
1g 19h
PR unite (30g)
117

Descrizione

🔍 Search Terms

strict index signatures

✅ Viability Checklist
⭐ Suggestion

Basically, I'm wondering if there's any interest to revisit #7029 and provide an option for an alternative balance.

To recap, the status quo is that object literal types (like {a: number}) are (intentionally unsoundly) considered assignable to index signature types (like {[k: string]: number}) as long as each property is assignable; but the exact same interface type is not:

function httpService(path: string, headers: { [h: string]: string }) { }

// A) direct object literal
httpService("/", { "Content-Type": "application/json" }) // ✅ ok

// B) object literal types
const headers = { "Content-Type": "application/json" }
httpService("/", headers) // ✅ ok

type HeadersTypeLiteral = { "Content-Type": string }
const headers2: HeadersTypeLiteral = headers
httpService("/", headers2) // ✅ ok

// C) interface type
interface HeadersInterface { "Content-Type": string }
const headers3: HeadersInterface = headers
httpService("/", headers3) // ❌ Type Error: Index signature missing...

This is totally sound for a direct object literal, of course, since we know it has no other properties (assuming no one messed with Object.prototype); but object literal types can come from anywhere, so that's pretty unsound. It's also a little surprising—I don't immediately know off the top of my head other cases where interface types vs interface literal types make such a big difference.

I understand this was an FAQ back in the day, but is there any way we could have the option of extra strictness, where direct object literals (A) above) are still assignable (they're already treated differently for excess property checks), but object literal types (B)) would behave more like interface types (C))?

Even more ideal of course would be if we distinguished between object literal types that come directly from object literal expressions in the same scope, vs inferred object literal types like cause the problem in the motivating example below. (If we did distinguish them, we could even extend excess property checks to the same-scope object literals!)

📃 Motivating Example

Consider this example, purely functional, seemingly correct types everywhere, and no typecasts (from this tweet):

function validateUsername(input: { username: string }) {
  console.assert(input.username.length < 30)
  return input
}

function printRecord(record: Record<string, string>) {
  for (const key in record) {
    const value = record[key]
    console.log(`${key}: ${value.trim().toLowerCase()}`) // 💥
  }
}

const account = {
  username: 'person',
  email: 'person@example.com',
  isAdmin: false,
}

const validated = validateUsername(account)
printRecord(validated)
💻 Use Cases
  1. What do you want to use this for?
    I want to trust TypeScript's inference in common cases

  2. What shortcomings exist with current approaches?
    Unsoundness without any red-flag features like typecasts, mutation, aliasing

  3. What workarounds are you using in the meantime?
    Manually checking for this bug 😕

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia esaminando l’issue #7029 e riproducendo l’esempio motivante con il compilatore TypeScript. Non sono indicati file di implementazione né percorsi dei test, quindi individua prima l’area del checker e i test rilevanti del sistema dei tipi, prima di proporre la semantica esatta dell’opzione. Il lavoro è completo quando il comportamento per i letterali diretti, i tipi oggetto inferiti e le interfacce è specificato e coperto dai test.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
typescript
Ambito
compilers
Tipo di issue
Funzionalità
Difficoltà
5/5
Tempo stimato
Più di una settimana
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
28/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.