microsoft / microsoft/TypeScript

Strict index signatures option

Open
#56,378 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

🔍 Search Terms

strict index signatures

✅ Viability Checklist
⭐ Suggestion

Basically, I'm wondering if there's any interest to revisit #7029 and provide an option for an alternative balance.

To recap, the status quo is that object literal types (like {a: number}) are (intentionally unsoundly) considered assignable to index signature types (like {[k: string]: number}) as long as each property is assignable; but the exact same interface type is not:

function httpService(path: string, headers: { [h: string]: string }) { }

// A) direct object literal
httpService("/", { "Content-Type": "application/json" }) // ✅ ok

// B) object literal types
const headers = { "Content-Type": "application/json" }
httpService("/", headers) // ✅ ok

type HeadersTypeLiteral = { "Content-Type": string }
const headers2: HeadersTypeLiteral = headers
httpService("/", headers2) // ✅ ok

// C) interface type
interface HeadersInterface { "Content-Type": string }
const headers3: HeadersInterface = headers
httpService("/", headers3) // ❌ Type Error: Index signature missing...

This is totally sound for a direct object literal, of course, since we know it has no other properties (assuming no one messed with Object.prototype); but object literal types can come from anywhere, so that's pretty unsound. It's also a little surprising—I don't immediately know off the top of my head other cases where interface types vs interface literal types make such a big difference.

I understand this was an FAQ back in the day, but is there any way we could have the option of extra strictness, where direct object literals (A) above) are still assignable (they're already treated differently for excess property checks), but object literal types (B)) would behave more like interface types (C))?

Even more ideal of course would be if we distinguished between object literal types that come directly from object literal expressions in the same scope, vs inferred object literal types like cause the problem in the motivating example below. (If we did distinguish them, we could even extend excess property checks to the same-scope object literals!)

📃 Motivating Example

Consider this example, purely functional, seemingly correct types everywhere, and no typecasts (from this tweet):

function validateUsername(input: { username: string }) {
  console.assert(input.username.length < 30)
  return input
}

function printRecord(record: Record<string, string>) {
  for (const key in record) {
    const value = record[key]
    console.log(`${key}: ${value.trim().toLowerCase()}`) // 💥
  }
}

const account = {
  username: 'person',
  email: 'person@example.com',
  isAdmin: false,
}

const validated = validateUsername(account)
printRecord(validated)
💻 Use Cases
  1. What do you want to use this for?
    I want to trust TypeScript's inference in common cases

  2. What shortcomings exist with current approaches?
    Unsoundness without any red-flag features like typecasts, mutation, aliasing

  3. What workarounds are you using in the meantime?
    Manually checking for this bug 😕

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing issue #7029 and reproducing the motivating example with the TypeScript compiler. No implementation file or test path is identified, so locate the checker area and relevant type-system tests before proposing the option's exact semantics. Done means the behavior for direct literals, inferred object types, and interfaces is specified and covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.