microsoft / microsoft/TypeScript
infinite generator transform is no longer infinite
@rbuckton ci sta già lavorando.
Dal 10/11/2023.
- Lingua principale
- Go
- Stelle
- 111k
- Fork
- 14.4k
- Merge medio
- 1g 19h
- PR unite (30g)
- 117
Descrizione
🔎 Search Terms
A function returning 'never' cannot have a reachable end point.
🕗 Version & Regression Information
This is the behavior in every version I tried, and I reviewed the FAQ for entries about never and generator.
⏯ Playground Link
💻 Code
function* cycle<T>(iterable: Iterable<T>): Generator<T, never, undefined> {
while (true) yield* iterable;
}
function* example(text: string): Generator<-1 | 1, never> {
for (const char of cycle(Array.from(text))) yield char === "<" ? -1 : 1;
}
🙁 Actual behavior
The second generator function build on top of the first where consumers of cycle do not need to check IteratorResult#done as the never return type is interpreted as never done. This is great for direct callers of cycle() but other generator functions building on top of cycle() are not inferred too as having a return type of never.
🙂 Expected behavior
A loop over an infinite generator (i.e. one with a return type of never) is also inferred as an infinite loop.
Additional information about the issue
A throw statement can be added after the loop as a workaround but I think this shouldn't be necessary:
function* example(text: string): Generator<-1 | 1, never> {
for (const char of cycle(Array.from(text))) yield char === "<" ? -1 : 1;
throw new Error("unreachable");
}
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Valutazione
Questa issue non è ancora stata valutata.