microsoft / microsoft/TypeScript
JSDoc `@overload`s on constructors don't capture class type parameters, can dictate their return type
Abierto
@sandersn ya está trabajando en esto.
Desde el 29/9/2023.
checkJs
Domain: JavaScript
Domain: JSDoc
Needs Investigation
- Lenguaje dominante
- Go
- Estrellas
- 111k
- Forks
- 14.4k
- Merge medio
- 1 d 19 h
- PR fusionados (30 d)
- 117
Descripción
Found from #55916.
Today if you try to write a generic constructor, captured type parameters fail to create a generic signature. Instead, the type parameter is effectively leaked and never instantiated.
/**
* @template T
*/
class C {
/**
* @overload
* @param {T} value
*/
/**
* @overload
* @param {T} first
* @param {T} second
*/
/**
* @param {T} first
* @param {T} [second]
*/
constructor(first, second) {
}
}
const x = new C(123);
// ~~~
// Argument of type 'number' is not assignable to parameter of type 'T'.
// 'T' could be instantiated with an arbitrary type which could be unrelated to 'number'.
const y = new C("hello", "world");
// ~~~~~~~
// Argument of type 'string' is not assignable to parameter of type 'T'.
// 'T' could be instantiated with an arbitrary type which could be unrelated to 'string'.
The current-workaround is to write something like the following:
/**
* @template T
*/
class C {
/**
* @template T
* @overload
* @param {T} value
* @return {C<T>}
*/
/**
* @template T
* @overload
* @param {T} first
* @param {T} second
* @return {C<T>}
*/
/**
* @param {T} first
* @param {T} [second]
*/
constructor(first, second) {
}
}
const x = new C(123);
// ^?
const y = new C("hello", "world");
// ^?
const y = new C(123, "hello");
// ^?
Notice that here, each @overload must declare its own type parameters and return type.
We should decide if this is actually how we want @overload to work in JSDoc on constructor declarations.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Evaluación
Este issue todavía no se ha evaluado.