microsoft / microsoft/TypeScript
Type instantiation is excessively deep with tuple spread
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Go
- Sterne
- 111k
- Forks
- 14.4k
- Ø Merge
- 1 T. 19 Std.
- Gemergte PRs (30 T.)
- 117
Beschreibung
Bug Report
🔎 Search Terms
- 2889 spread
🕗 Version & Regression Information
- This is the behavior in every version I tried (4.1.5 to 5.2.0 nightly), and I reviewed the FAQ for entries about: recursion
⏯ Playground Link
Playground link with relevant code
💻 Code
type NTuple<T, N extends number, Acc extends T[] = []> =
N extends Acc['length']
? Acc
: NTuple<T, N, [...Acc, T]>
type Pair = NTuple<number, 2>;
// ^? type Pair = [number, number]
type SpreadN<A extends number> = [...NTuple<any, A>]
// ~~~~~~~~~~~~~~~~~~~
// Type instantiation is excessively deep and possibly infinite. (2589)
🙁 Actual behavior
I'm getting the "Type instantiation is excessively deep and possibly infinite. (2589)" error on what should be the identity.
🙂 Expected behavior
I'd expect this to just work. SpreadN should produce the same results as NTuple. It's surprising to me that this error is produced on the definition of SpreadN, rather than when it's instantiated with an overly large value of N.
I think this may have something to do with distribution over unions because when I reverse the conditional, the code works fine:
type NTuple2<T, N extends number, Acc extends T[] = []> =
Acc['length'] extends N // note that the check is reversed
? Acc
: NTuple2<T, N, [...Acc, T]>
type SpreadN2<A extends number> = [...NTuple<any, A>] // ok
type Pair2 = SpreadN2<2>;
// ^? type Pair2 = [any, any]
It's not clear to me why reversing that conditional would matter, but it does have the effect of preventing distribution over unions, which is not desirable:
type T1 = NTuple<string, 2 | 3>;
// ^? type T1 = [string, string] | [string, string, string]
type T2 = NTuple2<string, 2 | 3>;
// ^? type T2 = [string, string]
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, das Tuple-Spread-Beispiel im verlinkten TypeScript Playground zu reproduzieren und NTuple mit NTuple2 zu vergleichen, einschließlich ihres Verhaltens über Unions hinweg. Erledigt ist es, wenn SpreadN an seiner Definition nicht mehr den Fehler 2589 meldet, während NTuple weiterhin die erwarteten verteilten Union-Ergebnisse beibehält.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- typescript
- Bereich
- compilers
- Issue-Typ
- Bug
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 25/100