microsoft / microsoft/TypeScript

Fails to expand indexed access type when used as a generic type parameter

Abierto
#54,776 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Domain: Indexed Access Types Help Wanted Possible Improvement
Lenguaje dominante
Go
Estrellas
111k
Forks
14.4k
Merge medio
1 d 19 h
PR fusionados (30 d)
117

Descripción

Bug Report

This logic is part of a proprietary DSL where the user wants to work with a number of types, specified as a record. Most of the time the user calls a function similar to

declare function someOtherFunction<T extends DiscriminatorRecord>(record: T): { [K in keyof T]: DiscriminatedUnion<T[K]> }

in which case there are no problems with the inference, but sometimes T needs to be restricted to have certain keys and values, as shown in the code below. One part of the problem that I wasn't able to reproduce in a code example was the fact that it did work with four types in the union, but failed when I added a fifth. Whereas in the example it fails with any number except one. I could spend more time on reproduction, but hopefully this will be helpful to start with.

🔎 Search Terms

generic indexed access type inference

🕗 Version & Regression Information
  • This is the behavior in every version (5.0.4, 5.1.3, v5.2.0-dev.20230625) I tried, and I reviewed the FAQ for entries about Type System Behavior, Generics
⏯ Playground Link

Playground link with relevant code

💻 Code
type Discriminator =
  | 'First'
  | 'Second'
  | 'Third'

type DiscriminatedUnion<D extends Discriminator> = { discriminator: D } & (
  | { discriminator: 'First', first: boolean }
  | { discriminator: 'Second', second: boolean }
  | { discriminator: 'Third', third: boolean }
  )

type DiscriminatorRecord = Record<string, Discriminator>

function someFunction<T extends DiscriminatorRecord & { override: 'Third' }>() {
  type DiscriminatorFromT = T['override'] // If this expands to 'Third'

  type DiscriminatedFromLiteral = DiscriminatedUnion<'Third'> // then this

  type DiscriminatedFromT = DiscriminatedUnion<DiscriminatorFromT> // should be equivalent to this

  const f1 = (d: DiscriminatedFromLiteral) => d.third; // yet this works
  const f2 = (d: DiscriminatedFromT) => d.third; // but not this
}

🙁 Actual behavior

const f2 = (d: DiscriminatedFromT) => d.third; fails with

Property 'third' does not exist on type 'DiscriminatedUnion<DiscriminatorFromT>'.
  Property 'third' does not exist on type '{ discriminator: DiscriminatorFromT; } & { discriminator: "First"; first: boolean; }'.
🙂 Expected behavior

The property third is inferred to exist on d in const f2 = (d: DiscriminatedFromT) => d.third;

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza con el TypeScript Playground enlazado y la reproducción del issue; después, compara el argumento genérico literal con el tipo de acceso indexado utilizado en DiscriminatedUnion. Confirma el comportamiento en las versiones indicadas y determina qué cambio hace que d.third se resuelva correctamente sin romper el comportamiento existente de la unión.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
typescript
Área
compilers
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
40/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.