microsoft / microsoft/TypeScript

Missing arguments in a callback function within a decorator result in error

Aperta
#54,587 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

@rbuckton ci sta già lavorando.

Dal 12/6/2023.

Needs Investigation
Lingua principale
Go
Stelle
111k
Fork
14.4k
Merge medio
1g 19h
PR unite (30g)
117

Descrizione

Bug Report

In TS 5.1.3 when writing decorators that use the experimentalDecorators setting,
and writing a decorator that receives a callback function in the factory, which it calls with the function this context and arguments, then TS fails with Unable to resolve signature of method decorator when called as an expression. when the callback function has not defined the argument in its callback, but works when it is present even if unused.

This even happens if the callback function is explicitly typed to also accept a version that does not take arguments.

🔎 Search Terms

Decorators, experimentalDecorators

🕗 Version & Regression Information

TS 5.1.3
experimentalDecorators enabled

⏯ Playground Link

Playground Link

💻 Code
type LogFn<C, A extends any[]> = (this: C, ...args: A) => string
function LoggingDecorator<C, A extends any[]>({ log }: { log: LogFn<C, A> }) {
  return function (
    _target: C,
    _methodName: string,
    descriptor: TypedPropertyDescriptor<(this: C, ...args: A) => Promise<any>>
  ) {
    const originalMethod = descriptor.value

    descriptor.value = function (this: C, ...args: A) {
      const result = log.apply(this, args)
      console.log(result)
      return originalMethod!.apply(this, args)
    }
  }
}

class NumberService {
  private number = 0
  // This errors
  @LoggingDecorator({
    log() {
      return `test-${this.number}`
    },
  })
  async setNumber(value: number): Promise<number> {
    this.number = value
    return this.number
  }

  // This works fine
  @LoggingDecorator({
    log(_number) {
      return `test-${this.number}`
    },
  })
  async setNumber2(value: number): Promise<number> {
    this.number = value
    return this.number
  }
}
🙁 Actual behavior

TS errors with

Unable to resolve signature of method decorator when called as an expression.
  Argument of type 'TypedPropertyDescriptor<(value: number) => Promise<number>>' is not assignable to parameter of type 'TypedPropertyDescriptor<(this: NumberService) => Promise<any>>'.
    Types of property 'value' are incompatible.
      Type '((value: number) => Promise<number>) | undefined' is not assignable to type '((this: NumberService) => Promise<any>) | undefined'.
        Type '(value: number) => Promise<number>' is not assignable to type '(this: NumberService) => Promise<any>'.ts(1241)
🙂 Expected behavior

TS accepts the function even without arguments.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.