Narrowing `this` using custom type predicate affected by TS 5.0

Bug Report

🔎 Search Terms

narrowing this predicate

🕗 Version & Regression Information

• This changed between versions 4.9 and 5.0

⏯ Playground Link

Playground link with relevant code

💻 Code

interface Typestate<TContext extends object> {
  value: string;
  context: TContext;
}

interface State<TContext extends object, TState extends Typestate<TContext>> {
  value: TState["value"];
  context: TContext;
  matches: <TSV extends TState["value"]>(
    value: TSV
  ) => this is TState extends {
    value: TSV;
  }
    ? TState & {
        value: TSV;
      }
    : never;
}

interface Machine<TContext extends object, TState extends Typestate<TContext>> {
  initialState: State<TContext, TState>;
}

export declare function createMachine<
  TContext extends object,
  TState extends Typestate<TContext> = {
    value: any;
    context: TContext;
  }
>(): Machine<TContext, TState>;

const machine = createMachine<{ count: number }>();
const state = machine.initialState;

if (state.matches("idle")) {
  ((_accept: number) => {})(state.context.count);
  // @ts-expect-error
  ((_accept: string) => {})(state.context.count);
} else if (state.matches("latest")) {
  ((_accept: number) => {})(state.context.count);
  // @ts-expect-error
  ((_accept: string) => {})(state.context.count);
}

🙁 Actual behavior

state gets narrowed down to never in the else branch

🙂 Expected behavior

state to only get narrowed down to the appropriate value within the if branch

cc @ahejlsberg

Inizia con il repro collegato in Playground e confronta il suo comportamento di narrowing tra TypeScript 4.9 e 5.0. Analizza il percorso di type-checking per i predicati personalizzati su this, quindi verifica che i rami if ed else vengano ristretti a stati appropriati e che i controlli @ts-expect-error inclusi abbiano esito positivo.