microsoft / microsoft/TypeScript

Unexpected behaviors in attribute completions of JSX/TSX

Ouverte
#52,873 9 commentaires 0 réactions 1 personne assignée Voir sur GitHub

@mjbvz y travaille déjà.

Depuis le 24/2/2023.

Needs Proposal Suggestion
Langage dominant
Go
Étoiles
111k
Forks
14.4k
Merge moyen
1 j 19 h
PR mergées (30 j)
117

Description

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.75.1
  • OS Version: Mac OS 13.1

Steps to Reproduce:

  1. Set the JSX attribute completion style of typescript to braces
  2. Create a .tsx file with the following content
export default function Sample(props: {}) {
    return <div
        
    > </div>
}
  1. for the div tag add a onClick callback with the following key strokes:
    3.1. oncl then enter
    3.2. e => { then enter
    3.3. e.st then enter

You can see the uploaded the gif below

Screen Recording 2023-02-11 at 12 01 52 PM

In JSX/TSX, there is an autocompletion for the attributes. When you select a suggested completion, a braces is opened and the cursor is placed in between in highlight mode, like the image below.

Screenshot 2023-02-11 at 12 33 29 PM

The existence of this highlight mode does not provide any value to the user. If you start typing in this highlight mode, the suggested codes are not selected (unlike the normal mode where the first suggested is selected and will be inserted when pressing enter) and if you want to come out of the highlight mode while typing, you have to press esc once to close the suggestion prompt and a second time to close the highlight mode.

In the above example, you would expect the editor to preselect the first suggestion (e.stopPropagation) and is inserted when pressing enter but since the code is in highlight mode, you have to press the down cursor to select the suggestion. If you don't select it manually, pressing enter adds a line break.

After using the jsx attribute completion from the day it was released, I haven't found any reason or use case for the highlight mode after code completion. My suggestion is that after the attribute is completed, the cursor would be placed between the braces in normal mode not in highlight mode.

P.S. I don't know what is the name used internally for the highlight mode (searched, but couldn't find), so if I'm wrong please correct me.

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.