microsoft / microsoft/TypeScript

[beta] Default imports behave as namespace imports for JSON modules with allowArbitraryExtensions

Abierto
#52,863 0 comentarios 0 reacciones 1 asignado Ver en GitHub

@weswigham ya está trabajando en esto.

Desde el 25/2/2023.

Needs Investigation Rescheduled
Lenguaje dominante
Go
Estrellas
111k
Forks
14.4k
Merge medio
1 d 19 h
PR fusionados (30 d)
117

Descripción

Bug Report

🔎 Search Terms

allowArbitraryExtensions, json modules, default import

🕗 Version & Regression Information

This is a problem with the new feature allowArbitraryExtensions in Typescript 5.0 beta.

⏯ Playground Link

This is a multi file issue so can't be replicated on the Playground.

💻 Code

TSconfig:

{
    "include": [
        "./**/*.ts",
        "./**/*.mts",
        "./**/*.cts",
        "./**/*.json"
    ],
    "exclude": [
        "./**/*.d.ts",
        "./**/*.d.mts",
        "./**/*.d.cts"
    ],
    "compilerOptions": {
        "composite": true,
        "declaration": true,
        "declarationMap": true,
        "downlevelIteration": true,
        "isolatedModules": true,
        "module": "NodeNext",
        "rootDir": "./",
        "sourceMap": true,
        "target": "esnext",
        "newLine": "lf",
        "useDefineForClassFields": true,
        "strict": true,
        "alwaysStrict": true,
        "exactOptionalPropertyTypes": true,
        "noImplicitOverride": true,
        "noUncheckedIndexedAccess": true,
        "importsNotUsedAsValues": "error",
        "forceConsistentCasingInFileNames": true,
        "allowArbitraryExtensions": true
    }
}

JSON file:

// mimeMap.json
{
    "text/javascript": ".js",
    "text/css": ".css",
    "text/html": ".html"
}

Declaration file for JSON:

// mimeMap.d.json.ts
declare const mimeMap: Record<string, string>;
export default mimeMap;

TS file:

import mimeMap from "./mimeMap.json" assert { type: "json" };

const mimeType = "some/mimetype";
const ext = mimeMap[mimeType];
🙁 Actual behavior

We get an error at mimeMap[mimeType]:

Element implicitly has an 'any' type because expression of type '"some/mimetype"' can't be used to index type 'typeof import("/home/jamesernator/projects/ts-issue/mimeMap.d.json", { assert: { "resolution-mode": "import" } })'.
  Property 'some/mimetype' does not exist on type 'typeof import("/home/jamesernator/projects/ts-issue/mimeMap.d.json", { assert: { "resolution-mode": "import" } })'.ts(7053)

This occurs because mimeMap has type { default: Record<string, string> } rather than just Record<string, string> as it should be.

🙂 Expected behavior

The JSON import should behave as a default import, not import the whole namespace as the default import. This worked correctly for other file types (other than .json) so I presume there is a conflict with the fact TS already has JSON module support (with resolveJsonModule).

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.